fix(ui): prevent query preset crash for relationship not_in filters#16625
Open
sisodiaumang wants to merge 2 commits into
Open
fix(ui): prevent query preset crash for relationship not_in filters#16625sisodiaumang wants to merge 2 commits into
sisodiaumang wants to merge 2 commits into
Conversation
b2c510c to
a768ca3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes a runtime crash when rendering query presets containing relationship
not_infilters.The issue occurred in:
The
WhereCellcomponent passed non-string array values intotoWords, which expects a string and internally calls.trim().This caused the query preset selector UI to crash with:
Why?
Relationship
not_infilters can contain non-string values inside the filter array.These values were passed directly into
toWords, which assumes string input and crashes when.trim()is called on unsupported types.This issue made query presets unusable after saving affected filters.
How?
Safely stringify array values before passing them into
toWords.Updated:
to:
This prevents the runtime crash while preserving existing behavior.
Fixes #16614