Fix goroutine leak: add missing return after doneChan send in LocateSchemaPropertyNodeByJSONPath

Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>

Author: SebTardif

schema_validation/locate_schema_property.go

@@ -13,20 +13,23 @@ import (
 // LocateSchemaPropertyNodeByJSONPath will locate a schema property node by a JSONPath. It converts something like
 // #/components/schemas/MySchema/properties/MyProperty to something like $.components.schemas.MySchema.properties.MyProperty
 func LocateSchemaPropertyNodeByJSONPath(doc *yaml.Node, JSONPath string) *yaml.Node {
+	_, path := utils.ConvertComponentIdIntoFriendlyPathSearch(JSONPath)
+	return locateSchemaPropertyNode(doc, path)
+}
+
+func locateSchemaPropertyNode(doc *yaml.Node, path string) *yaml.Node {
+	if path == "" {
+		return nil
+	}
 	var locatedNode *yaml.Node
 	doneChan := make(chan bool)
 	locatedNodeChan := make(chan *yaml.Node)
 	go func() {
 		defer func() {
 			if err := recover(); err != nil {
-				// can't search path, too crazy.
 				doneChan <- true
 			}
 		}()
-		_, path := utils.ConvertComponentIdIntoFriendlyPathSearch(JSONPath)
-		if path == "" {
-			doneChan <- true
-		}
 		jsonPath, _ := jsonpath.NewPath(path, config.WithLazyContextTracking())
 		locatedNodes := jsonPath.Query(doc)
 		if len(locatedNodes) > 0 {

schema_validation/locate_schema_property_test.go

@@ -12,3 +12,7 @@ import (
 func TestLocateSchemaPropertyNodeByJSONPath_BadNode(t *testing.T) {
 	assert.Nil(t, LocateSchemaPropertyNodeByJSONPath(nil, ""))
 }
+
+func TestLocateSchemaPropertyNode_EmptyPath(t *testing.T) {
+	assert.Nil(t, locateSchemaPropertyNode(nil, ""))
+}