Cache YAML Nodes#222
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
=======================================
Coverage 97.58% 97.59%
=======================================
Files 56 56
Lines 5176 5190 +14
=======================================
+ Hits 5051 5065 +14
Misses 125 125
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
its-hammer-time
force-pushed
the
cache-yaml-nodes
branch
3 times, most recently
from
f7d1738 to
c3f0207
Compare
its-hammer-time
force-pushed
the
cache-yaml-nodes
branch
from
c3f0207 to
6bb4745
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For error responses, we return the YAML OpenAPI schema so the user can see the exact schema which failed during validation. However, this requires us to unmarshal it on every error so instead I'm adding it to the cache and we can just reuse it.