Fix Windows CI test hangs

Author: daveshanley

.github/workflows/build.yaml

@@ -28,7 +28,7 @@ jobs:
         run: go mod download
 
       - name: Test
-        run: go test ./...
+        run: go test -v -count=1 -timeout=3m ./...
 
       - name: Build
         run: go build -o openapi-changes.exe .

cmd/loaders_test.go

@@ -308,6 +308,10 @@ func TestLoadCommitsFromArgs_GitRefUsesLeftRightDispatch(t *testing.T) {
 }
 
 func TestLoadCommitsFromArgs_LocalColonPathOutsideGitRepoStaysFileComparison(t *testing.T) {
+	if os.PathSeparator == '\\' {
+		t.Skip("colon filenames are not portable on Windows")
+	}
+
 	dir := t.TempDir()
 	chdirForTest(t, dir)
 
@@ -325,6 +329,10 @@ func TestLoadCommitsFromArgs_LocalColonPathOutsideGitRepoStaysFileComparison(t *
 }
 
 func TestLoadCommitsFromArgs_RepoHistoryColonPathUsesHistoryDispatch(t *testing.T) {
+	if os.PathSeparator == '\\' {
+		t.Skip("colon filenames are not portable on Windows")
+	}
+
 	repoDir := createGitSpecRepoForFile(t, "v1:beta.yaml")
 	chdirForTest(t, t.TempDir())
 

cmd/markdown_report_test.go

@@ -4,6 +4,7 @@
 package cmd
 
 import (
+	"path/filepath"
 	"strings"
 	"testing"
 	"time"
@@ -273,7 +274,7 @@ func TestMarkdownReportCommand_TooManyArgs(t *testing.T) {
 func TestMarkdownReportCommand_LeftRightFiles(t *testing.T) {
 	cmd := testRootCmd(GetMarkdownReportCommand(),
 		"--no-logo", "--no-color",
-		"--report-file", "/dev/null",
+		"--report-file", filepath.Join(t.TempDir(), "report.md"),
 		"../sample-specs/petstorev3-original.json",
 		"../sample-specs/petstorev3.json",
 	)

cmd/paths_test.go

@@ -18,7 +18,7 @@ func TestAbsoluteRepoPath(t *testing.T) {
 	})
 
 	t.Run("returns absolute path", func(t *testing.T) {
-		p := "/home/user/repo"
+		p := t.TempDir()
 
 		have, err := absoluteRepoPath(p)
 		assert.NoError(t, err)

cmd/summary_test.go

@@ -28,20 +28,32 @@ func captureStdout(t *testing.T, fn func()) string {
 	reader, writer, err := os.Pipe()
 	require.NoError(t, err)
 
+	outputCh := make(chan struct {
+		data []byte
+		err  error
+	}, 1)
+	go func() {
+		data, readErr := io.ReadAll(reader)
+		outputCh <- struct {
+			data []byte
+			err  error
+		}{data: data, err: readErr}
+	}()
+
 	os.Stdout = writer
 	t.Cleanup(func() {
 		os.Stdout = oldStdout
 	})
 
 	fn()
 
+	os.Stdout = oldStdout
 	require.NoError(t, writer.Close())
-	output, err := io.ReadAll(reader)
-	require.NoError(t, err)
+	output := <-outputCh
+	require.NoError(t, output.err)
 	require.NoError(t, reader.Close())
-	os.Stdout = oldStdout
 
-	return string(output)
+	return string(output.data)
 }
 
 func captureStderr(t *testing.T, fn func()) string {
@@ -51,20 +63,32 @@ func captureStderr(t *testing.T, fn func()) string {
 	reader, writer, err := os.Pipe()
 	require.NoError(t, err)
 
+	outputCh := make(chan struct {
+		data []byte
+		err  error
+	}, 1)
+	go func() {
+		data, readErr := io.ReadAll(reader)
+		outputCh <- struct {
+			data []byte
+			err  error
+		}{data: data, err: readErr}
+	}()
+
 	os.Stderr = writer
 	t.Cleanup(func() {
 		os.Stderr = oldStderr
 	})
 
 	fn()
 
+	os.Stderr = oldStderr
 	require.NoError(t, writer.Close())
-	output, err := io.ReadAll(reader)
-	require.NoError(t, err)
+	output := <-outputCh
+	require.NoError(t, output.err)
 	require.NoError(t, reader.Close())
-	os.Stderr = oldStderr
 
-	return string(output)
+	return string(output.data)
 }
 
 func mustMakeDoctorOnlyCommitFromSpecs(t *testing.T, hash, left, right string) *model.Commit {