#3576 harper: remove obsolete linters and add new ones

pbek · pbek · commit 6553f974ddaf · 2026-04-24T19:29:30.000+02:00
Signed-off-by: Patrizio Bekerle &lt;patrizio@bekerle.com&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,10 @@
 - Fixed the **Harper** settings status row so the `Status:` label is aligned with
   the status text again and the result text no longer repeats the `Status:`
   prefix in the **Settings dialog** (for [#3576](https://github.com/pbek/QOwnNotes/issues/3576))
+- Updated the **Harper** linter list in the **Settings dialog** to remove the
+  upstream-deleted `Matcher` and `Wrong Quotes` rules and add `Quote Spacing`,
+  `No French Spaces`, and `Wrong Apostrophe` instead (for
+  [#3576](https://github.com/pbek/QOwnNotes/issues/3576))
 
 ## 26.4.20
 
diff --git a/src/services/harperchecker.cpp b/src/services/harperchecker.cpp
@@ -314,7 +314,9 @@ void HarperChecker::readSettings() {
                                  << QStringLiteral("SentenceCapitalization")
                                  << QStringLiteral("RepeatedWords")
                                  << QStringLiteral("LongSentences") << QStringLiteral("Spaces")
-                                 << QStringLiteral("Matcher")
+                                 << QStringLiteral("QuoteSpacing")
+                                 << QStringLiteral("NoFrenchSpaces")
+                                 << QStringLiteral("WrongApostrophe")
                                  << QStringLiteral("CorrectNumberSuffix")
                                  << QStringLiteral("UnclosedQuotes"))
             .toStringList();
diff --git a/src/services/harperclient.cpp b/src/services/harperclient.cpp
@@ -258,11 +258,12 @@ QJsonObject buildHarperConfigurationObject(const HarperClient::RequestOptions &o
                                       QStringLiteral("AnA"),
                                       QStringLiteral("SentenceCapitalization"),
                                       QStringLiteral("UnclosedQuotes"),
-                                      QStringLiteral("WrongQuotes"),
+                                      QStringLiteral("WrongApostrophe"),
+                                      QStringLiteral("QuoteSpacing"),
+                                      QStringLiteral("NoFrenchSpaces"),
                                       QStringLiteral("LongSentences"),
                                       QStringLiteral("RepeatedWords"),
                                       QStringLiteral("Spaces"),
-                                      QStringLiteral("Matcher"),
                                       QStringLiteral("CorrectNumberSuffix")};
     for (const QString &linter : knownLinters) {
         linters.insert(linter, options.enabledLinters.contains(linter));
@@ -893,15 +894,16 @@ QString HarperClient::categoryForRuleId(const QString &ruleId) {
         return QStringLiteral("Grammar");
     }
     if ((normalized == QStringLiteral("LongSentences")) ||
-        (normalized == QStringLiteral("Matcher")) ||
         (normalized == QStringLiteral("SpelledNumbers"))) {
         return QStringLiteral("Style");
     }
     if ((normalized == QStringLiteral("Spaces")) ||
-        (normalized == QStringLiteral("UnclosedQuotes"))) {
+        (normalized == QStringLiteral("UnclosedQuotes")) ||
+        (normalized == QStringLiteral("QuoteSpacing")) ||
+        (normalized == QStringLiteral("NoFrenchSpaces"))) {
         return QStringLiteral("Punctuation");
     }
-    if (normalized == QStringLiteral("WrongQuotes")) {
+    if (normalized == QStringLiteral("WrongApostrophe")) {
         return QStringLiteral("Typography");
     }
 
diff --git a/src/widgets/settings/harpersettingswidget.cpp b/src/widgets/settings/harpersettingswidget.cpp
@@ -102,7 +102,9 @@ void HarperSettingsWidget::readSettings() {
                                  << QStringLiteral("SentenceCapitalization")
                                  << QStringLiteral("RepeatedWords")
                                  << QStringLiteral("LongSentences") << QStringLiteral("Spaces")
-                                 << QStringLiteral("Matcher")
+                                 << QStringLiteral("QuoteSpacing")
+                                 << QStringLiteral("NoFrenchSpaces")
+                                 << QStringLiteral("WrongApostrophe")
                                  << QStringLiteral("CorrectNumberSuffix")
                                  << QStringLiteral("UnclosedQuotes"))
             .toStringList();
@@ -119,9 +121,12 @@ void HarperSettingsWidget::readSettings() {
     ui->harperCorrectNumberSuffixCheckBox->setChecked(
         enabledLinters.contains(QStringLiteral("CorrectNumberSuffix")));
     ui->harperSpacesCheckBox->setChecked(enabledLinters.contains(QStringLiteral("Spaces")));
-    ui->harperMatcherCheckBox->setChecked(enabledLinters.contains(QStringLiteral("Matcher")));
-    ui->harperWrongQuotesCheckBox->setChecked(
-        enabledLinters.contains(QStringLiteral("WrongQuotes")));
+    ui->harperQuoteSpacingCheckBox->setChecked(
+        enabledLinters.contains(QStringLiteral("QuoteSpacing")));
+    ui->harperNoFrenchSpacesCheckBox->setChecked(
+        enabledLinters.contains(QStringLiteral("NoFrenchSpaces")));
+    ui->harperWrongApostropheCheckBox->setChecked(
+        enabledLinters.contains(QStringLiteral("WrongApostrophe")));
     ui->harperSpelledNumbersCheckBox->setChecked(
         enabledLinters.contains(QStringLiteral("SpelledNumbers")));
 
@@ -173,11 +178,14 @@ QStringList HarperSettingsWidget::enabledLintersFromUi() const {
     if (ui->harperSpacesCheckBox->isChecked()) {
         linters.append(QStringLiteral("Spaces"));
     }
-    if (ui->harperMatcherCheckBox->isChecked()) {
-        linters.append(QStringLiteral("Matcher"));
+    if (ui->harperQuoteSpacingCheckBox->isChecked()) {
+        linters.append(QStringLiteral("QuoteSpacing"));
     }
-    if (ui->harperWrongQuotesCheckBox->isChecked()) {
-        linters.append(QStringLiteral("WrongQuotes"));
+    if (ui->harperNoFrenchSpacesCheckBox->isChecked()) {
+        linters.append(QStringLiteral("NoFrenchSpaces"));
+    }
+    if (ui->harperWrongApostropheCheckBox->isChecked()) {
+        linters.append(QStringLiteral("WrongApostrophe"));
     }
     if (ui->harperSpelledNumbersCheckBox->isChecked()) {
         linters.append(QStringLiteral("SpelledNumbers"));
diff --git a/src/widgets/settings/harpersettingswidget.ui b/src/widgets/settings/harpersettingswidget.ui
@@ -81,11 +81,12 @@
             <item row="1" column="0"><widget class="QCheckBox" name="harperLongSentencesCheckBox"><property name="text"><string>Long Sentences</string></property></widget></item>
             <item row="1" column="1"><widget class="QCheckBox" name="harperAnACheckBox"><property name="text"><string>An vs A</string></property></widget></item>
             <item row="1" column="2"><widget class="QCheckBox" name="harperUnclosedQuotesCheckBox"><property name="text"><string>Unclosed Quotes</string></property></widget></item>
-            <item row="2" column="0"><widget class="QCheckBox" name="harperCorrectNumberSuffixCheckBox"><property name="text"><string>Correct Number Suffix</string></property></widget></item>
-            <item row="2" column="1"><widget class="QCheckBox" name="harperSpacesCheckBox"><property name="text"><string>Spaces</string></property></widget></item>
-            <item row="2" column="2"><widget class="QCheckBox" name="harperMatcherCheckBox"><property name="text"><string>Matcher</string></property></widget></item>
-            <item row="3" column="0"><widget class="QCheckBox" name="harperWrongQuotesCheckBox"><property name="text"><string>Wrong Quotes</string></property></widget></item>
-            <item row="3" column="1"><widget class="QCheckBox" name="harperSpelledNumbersCheckBox"><property name="text"><string>Spelled Numbers</string></property></widget></item>
+             <item row="2" column="0"><widget class="QCheckBox" name="harperCorrectNumberSuffixCheckBox"><property name="text"><string>Correct Number Suffix</string></property></widget></item>
+             <item row="2" column="1"><widget class="QCheckBox" name="harperSpacesCheckBox"><property name="text"><string>Spaces</string></property></widget></item>
+             <item row="2" column="2"><widget class="QCheckBox" name="harperQuoteSpacingCheckBox"><property name="text"><string>Quote Spacing</string></property></widget></item>
+             <item row="3" column="0"><widget class="QCheckBox" name="harperNoFrenchSpacesCheckBox"><property name="text"><string>No French Spaces</string></property></widget></item>
+             <item row="3" column="1"><widget class="QCheckBox" name="harperWrongApostropheCheckBox"><property name="text"><string>Wrong Apostrophe</string></property></widget></item>
+             <item row="3" column="2"><widget class="QCheckBox" name="harperSpelledNumbersCheckBox"><property name="text"><string>Spelled Numbers</string></property></widget></item>
            </layout>
           </widget>
          </item>
diff --git a/webpage/src/editor/harper.md b/webpage/src/editor/harper.md
@@ -44,8 +44,9 @@ Open `Settings` and select `Editor -> Harper`.
   - `Unclosed Quotes`
   - `Correct Number Suffix`
   - `Spaces`
-  - `Matcher`
-  - `Wrong Quotes`
+  - `Quote Spacing`
+  - `No French Spaces`
+  - `Wrong Apostrophe`
   - `Spelled Numbers`
 
 Use `Test Connection` to verify that QOwnNotes can either start `harper-ls` in `Stdio` mode or
