[FEATURE] improve text searching

[ipariparipa]

this is bit related to #3538

my suggestion is to never scroll the view when starting text search with selection. this woud be as the same behavior as kate/QtCreator/VisualStudio etc.

the solution is relative easy, let me attach two patch files with the needed modification.

qmarkdowntextedit__improve_text_search.patch
QOwnNotes__improve_text_search.patch

[pbek]

my suggestion is to never scroll the view when starting text search with selection.

I'm not sure what you are talking about.
Can you please describe what you expected, what the actual behavior was, and step by step what you did?

[pbek]

This is what I understood:

26.4.5

• When searching with selected text via Ctrl+F in the note text edit,
  the preview, or the QLiteHTML preview, the first result now highlights
  the originally selected occurrence instead of jumping to the next one, so the
  editor/view no longer scrolls away from the user's current position
  (for #3541)

[pbek]

There now is a new release, could you please test it and report if it works for you?

[ipariparipa]

"the first result now highlights the originally selected occurrence instead of jumping to the next one" — OK
"so the editor/view no longer scrolls away" — unfortunately this is not true, because the view is definitely scrolled sometimes.

• try to open a longer (more pages) text
• scroll somewhere to middle of the document
• select a really frequent word somewhere in the middle of your screen
• Ctrl+F
• the originally selected word will be highlighted (OK), but the view is scrolled as well (NOK)

the solution I posted solves this problem too by moving the scrollbars to their original position. yes, it seems like a workaround, but I haven't found a better solution because the actual position in the document is moved when the search is started which induces a scrolling.

//get the positions
const auto v_pos = _textEdit->verticalScrollBar()->value();
const auto h_pos = _textEdit->horizontalScrollBar()->value();

// ...doing something...

//reset the original positions
_textEdit->verticalScrollBar()->setValue(v_pos);
_textEdit->horizontalScrollBar()->setValue(h_pos);

for good example just check the mentioned applications: kate/QtCreator/VisualStudio. the view never should be moved in this case.

[pbek]

Ah, now I got it. Good step-by-step guide. 😉 The scrolling is a side effect from searching.

[pbek]

26.4.7

• Opening the search bar in the note text edit, the preview, or the
  QLiteHTML preview now keeps the current horizontal and vertical scroll position
  during the initial search, so highlighting the first match no longer scrolls the
  view away from where you were reading (for #3541)

There now is a new release, could you please test it and report if it works for you?