fix(AttachmentService): update referenced attachment file IDs when copying markdown files

Signed-off-by: Peter Birrer <peter.birrer@optonic.com>

Author: pbirrer

lib/Listeners/NodeCopiedListener.php

@@ -36,9 +36,10 @@ public function handle(Event $event): void {
 			&& $target instanceof File
 			&& $target->getMimeType() === 'text/markdown'
 		) {
-			$this->attachmentService->copyAttachments($source, $target);
+			$fileIdMapping = $this->attachmentService->copyAttachments($source, $target);
 			$target->unlock(ILockingProvider::LOCK_SHARED);
 			AttachmentService::replaceAttachmentFolderId($source, $target);
+			AttachmentService::replaceAttachmentFileIds($target, $fileIdMapping);
 			$target->lock(ILockingProvider::LOCK_SHARED);
 		}
 	}

lib/Service/AttachmentService.php

@@ -693,27 +693,34 @@ public function deleteAttachments(File $source): void {
 	 * @param File $source
 	 * @param File $target
 	 *
+	 * @return array file id translation map
 	 * @throws InvalidPathException
 	 * @throws NoUserException
 	 * @throws NotFoundException
 	 * @throws NotPermittedException
 	 * @throws LockedException
 	 */
-	public function copyAttachments(File $source, File $target): void {
+	public function copyAttachments(File $source, File $target): array {
 		try {
 			$sourceAttachmentDir = $this->getAttachmentDirectoryForFile($source);
 		} catch (NotFoundException $e) {
 			// silently return if no attachment dir was found for source file
-			return;
+			return [];
 		}
 		// create a new attachment dir next to the new file
 		$targetAttachmentDir = $this->getAttachmentDirectoryForFile($target, true);
 		// copy the attachment files
+		$fileIdMapping = [];
 		foreach ($sourceAttachmentDir->getDirectoryListing() as $sourceAttachment) {
 			if ($sourceAttachment instanceof File) {
-				$targetAttachmentDir->newFile($sourceAttachment->getName(), $sourceAttachment->getContent());
+				$newFile = $targetAttachmentDir->newFile($sourceAttachment->getName(), $sourceAttachment->getContent());
+				$fileIdMapping[] = [
+					$sourceAttachment->getId(),
+					$newFile->getId()
+				];
 			}
 		}
+		return $fileIdMapping;
 	}
 
 	public static function replaceAttachmentFolderId(File $source, File $target): void {
@@ -735,4 +742,18 @@ public static function replaceAttachmentFolderId(File $source, File $target): vo
 			$target->putContent($content);
 		}
 	}
+
+	public static function replaceAttachmentFileIds(File $target, array $fileIdMapping): void {
+		$targetId = $target->getId();
+		$patterns = [];
+		$replacements = [];
+		foreach ($fileIdMapping as $mapping) {
+			$patterns[] = '/\[\b((\S+\/f\/)' . $mapping[0] . ')\b\]\(\b\1\b/';
+			$replacements[] = '[${2}' . $mapping[1] . '](${2}' . $mapping[1];
+		}
+		$content = preg_replace($patterns, $replacements, $target->getContent());
+		if ($content !== null) {
+			$target->putContent($content);
+		}
+	}
 }