Restructured to work with specific headers and orders#47
Open
lslinnet wants to merge 3 commits into
Open
Conversation
|
@pbojinov can you please take a look at this pull request please, since this module isn't usable with Cloudflare anymore (they changed header content) ? |
|
just wanted to bump this. any updates? |
Contributor
|
Hi @adarshmadrecha I'm not the maintainer. |
|
Is this project more or less abandoned because no new PR has been merged in the last 3 years? |
Author
|
@pbojinov any comments on this? I have been running this in production for almost 2 years now and it works very smoothly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #26 I have restructured the code to allow for deciding which headers to use and what order they should be chosen in. It defaults back to how it works today so I do not believe any backward compatibility will be lost.