Translate PDF: Fix name of destination language parameter

Assisted-by: Codex

Author: datalogics-cgreen

src/pdfrest/client.py

@@ -2170,8 +2170,7 @@ def translate_pdf_text(
         self,
         file: PdfRestFile | Sequence[PdfRestFile],
         *,
-        target_language: str,
-        source_language: str | None = None,
+        output_language: str,
         pages: PdfPageSelection | None = None,
         output_format: TranslateOutputFormat = "markdown",
         output: str | None = None,
@@ -2184,12 +2183,10 @@ def translate_pdf_text(
 
         payload: dict[str, Any] = {
             "files": file,
-            "target_language": target_language,
+            "output_language": output_language,
             "output_format": output_format,
             "output_type": "json",
         }
-        if source_language is not None:
-            payload["source_language"] = source_language
         if pages is not None:
             payload["pages"] = pages
         if output is not None:
@@ -2214,8 +2211,7 @@ def translate_pdf_text_to_file(
         self,
         file: PdfRestFile | Sequence[PdfRestFile],
         *,
-        target_language: str,
-        source_language: str | None = None,
+        output_language: str,
         pages: PdfPageSelection | None = None,
         output_format: TranslateOutputFormat = "markdown",
         output: str | None = None,
@@ -2228,12 +2224,10 @@ def translate_pdf_text_to_file(
 
         payload: dict[str, Any] = {
             "files": file,
-            "target_language": target_language,
+            "output_language": output_language,
             "output_format": output_format,
             "output_type": "file",
         }
-        if source_language is not None:
-            payload["source_language"] = source_language
         if pages is not None:
             payload["pages"] = pages
         if output is not None:
@@ -3093,8 +3087,7 @@ async def translate_pdf_text(
         self,
         file: PdfRestFile | Sequence[PdfRestFile],
         *,
-        target_language: str,
-        source_language: str | None = None,
+        output_language: str,
         pages: PdfPageSelection | None = None,
         output_format: TranslateOutputFormat = "markdown",
         output: str | None = None,
@@ -3107,12 +3100,10 @@ async def translate_pdf_text(
 
         payload: dict[str, Any] = {
             "files": file,
-            "target_language": target_language,
+            "output_language": output_language,
             "output_format": output_format,
             "output_type": "json",
         }
-        if source_language is not None:
-            payload["source_language"] = source_language
         if pages is not None:
             payload["pages"] = pages
         if output is not None:
@@ -3137,8 +3128,7 @@ async def translate_pdf_text_to_file(
         self,
         file: PdfRestFile | Sequence[PdfRestFile],
         *,
-        target_language: str,
-        source_language: str | None = None,
+        output_language: str,
         pages: PdfPageSelection | None = None,
         output_format: TranslateOutputFormat = "markdown",
         output: str | None = None,
@@ -3151,12 +3141,10 @@ async def translate_pdf_text_to_file(
 
         payload: dict[str, Any] = {
             "files": file,
-            "target_language": target_language,
+            "output_language": output_language,
             "output_format": output_format,
             "output_type": "file",
         }
-        if source_language is not None:
-            payload["source_language"] = source_language
         if pages is not None:
             payload["pages"] = pages
         if output is not None:

src/pdfrest/models/_internal.py

@@ -420,13 +420,10 @@ class TranslatePdfTextPayload(BaseModel):
         ),
         PlainSerializer(_serialize_as_first_file_id),
     ]
-    target_language: Annotated[
-        str, Field(serialization_alias="target_language", min_length=1)
+    output_language: Annotated[
+        str,
+        Field(serialization_alias="output_language", min_length=1),
     ]
-    source_language: Annotated[
-        str | None,
-        Field(serialization_alias="source_language", min_length=1, default=None),
-    ] = None
     pages: Annotated[
         list[AscendingPageRange] | None,
         Field(serialization_alias="pages", min_length=1, default=None),

tests/live/test_live_translate_pdf_text.py

@@ -20,7 +20,7 @@ def test_live_translate_pdf_text_success(
         uploaded = client.files.create_from_paths([resource])[0]
         response = client.translate_pdf_text(
             uploaded,
-            target_language="fr",
+            output_language="fr",
             output_format="plaintext",
         )
 
@@ -42,7 +42,7 @@ def test_live_translate_pdf_text_invalid_output_format(
         with pytest.raises(PdfRestApiError, match="error"):
             client.translate_pdf_text(
                 uploaded,
-                target_language="es",
+                output_language="es",
                 extra_body={"output_format": "invalid-format"},
             )
 
@@ -59,7 +59,7 @@ def test_live_translate_pdf_text_file_success(
         uploaded = client.files.create_from_paths([resource])[0]
         response = client.translate_pdf_text_to_file(
             uploaded,
-            target_language="fr",
+            output_language="fr",
             output_format="plaintext",
         )
 

tests/test_translate_pdf_text.py

@@ -50,7 +50,7 @@ def test_translate_payload_rejects_invalid_mime() -> None:
         ValidationError, match="Must be a PDF, Markdown, or plain text file"
     ):
         TranslatePdfTextPayload.model_validate(
-            {"files": [image_file], "target_language": "fr"}
+            {"files": [image_file], "output_language": "fr"}
         )
 
 
@@ -66,8 +66,7 @@ def test_translate_pdf_text_json_success(monkeypatch: pytest.MonkeyPatch) -> Non
     payload_dump = TranslatePdfTextPayload.model_validate(
         {
             "files": [input_file],
-            "target_language": "fr",
-            "source_language": "en",
+            "output_language": "fr",
             "pages": ["1-2"],
             "output_format": "plaintext",
             "output_type": "json",
@@ -96,8 +95,7 @@ def handler(request: httpx.Request) -> httpx.Response:
     with PdfRestClient(api_key=VALID_API_KEY, transport=transport) as client:
         response = client.translate_pdf_text(
             input_file,
-            target_language="fr",
-            source_language="en",
+            output_language="fr",
             pages=["1-2"],
             output_format="plaintext",
             output="translation",
@@ -119,7 +117,7 @@ def test_translate_pdf_text_request_customization(
     payload_dump = TranslatePdfTextPayload.model_validate(
         {
             "files": [input_file],
-            "target_language": "es",
+            "output_language": "es",
             "output_type": "file",
         }
     ).model_dump(mode="json", by_alias=True, exclude_none=True, exclude_unset=True)
@@ -151,7 +149,7 @@ def handler(request: httpx.Request) -> httpx.Response:
     with PdfRestClient(api_key=VALID_API_KEY, transport=transport) as client:
         response = client.translate_pdf_text_to_file(
             input_file,
-            target_language="es",
+            output_language="es",
             extra_query={"trace": "true"},
             extra_headers={"X-Debug": "sync"},
             extra_body={"debug": True},
@@ -177,7 +175,7 @@ async def test_async_translate_pdf_text_success(
     monkeypatch.delenv("PDFREST_API_KEY", raising=False)
     input_file = make_pdf_file(PdfRestFileID.generate(2))
     payload_dump = TranslatePdfTextPayload.model_validate(
-        {"files": [input_file], "target_language": "de", "output_type": "json"}
+        {"files": [input_file], "output_language": "de", "output_type": "json"}
     ).model_dump(mode="json", by_alias=True, exclude_none=True, exclude_unset=True)
 
     seen: dict[str, int] = {"post": 0}
@@ -202,7 +200,7 @@ def handler(request: httpx.Request) -> httpx.Response:
     async with AsyncPdfRestClient(api_key=ASYNC_API_KEY, transport=transport) as client:
         response = await client.translate_pdf_text(
             input_file,
-            target_language="de",
+            output_language="de",
         )
 
     assert seen == {"post": 1}