Skip to content

Commit 5b1e4d5

Browse files
tests: Stabilize live convert-colors custom-profile live tests
Update sync and async custom-profile live tests to upload both the source PDF and ICC profile within the same client context that performs `convert_colors`. This avoids intermittent CI failures where reused uploaded IDs can be rejected by the server with "The ID is invalid." Assisted-by: Codex
1 parent 211e187 commit 5b1e4d5

1 file changed

Lines changed: 16 additions & 12 deletions

File tree

tests/live/test_live_convert_colors.py

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -75,16 +75,18 @@ def test_live_convert_colors_color_profiles_success(
7575
def test_live_convert_colors_custom_profile_success(
7676
pdfrest_api_key: str,
7777
pdfrest_live_base_url: str,
78-
uploaded_pdf_for_color_conversion: PdfRestFile,
79-
uploaded_custom_profile_for_color_conversion: PdfRestFile,
8078
) -> None:
79+
pdf_resource = get_test_resource_path("report.pdf")
80+
profile_resource = get_test_resource_path("custom.icc")
8181
with PdfRestClient(
8282
api_key=pdfrest_api_key,
8383
base_url=pdfrest_live_base_url,
8484
) as client:
85+
uploaded_pdf = client.files.create_from_paths([pdf_resource])[0]
86+
uploaded_profile = client.files.create_from_paths([profile_resource])[0]
8587
response = client.convert_colors(
86-
uploaded_pdf_for_color_conversion,
87-
color_profile=uploaded_custom_profile_for_color_conversion,
88+
uploaded_pdf,
89+
color_profile=uploaded_profile,
8890
)
8991

9092
assert response.output_files
@@ -93,8 +95,8 @@ def test_live_convert_colors_custom_profile_success(
9395
assert output_file.size > 0
9496
assert response.warning is None
9597
input_ids = {str(file_id) for file_id in response.input_ids}
96-
assert str(uploaded_pdf_for_color_conversion.id) in input_ids
97-
assert str(uploaded_custom_profile_for_color_conversion.id) in input_ids
98+
assert str(uploaded_pdf.id) in input_ids
99+
assert str(uploaded_profile.id) in input_ids
98100

99101

100102
@pytest.mark.parametrize(
@@ -167,16 +169,18 @@ async def test_live_async_convert_colors_color_profiles_success(
167169
async def test_live_async_convert_colors_custom_profile_success(
168170
pdfrest_api_key: str,
169171
pdfrest_live_base_url: str,
170-
uploaded_pdf_for_color_conversion: PdfRestFile,
171-
uploaded_custom_profile_for_color_conversion: PdfRestFile,
172172
) -> None:
173+
pdf_resource = get_test_resource_path("report.pdf")
174+
profile_resource = get_test_resource_path("custom.icc")
173175
async with AsyncPdfRestClient(
174176
api_key=pdfrest_api_key,
175177
base_url=pdfrest_live_base_url,
176178
) as client:
179+
uploaded_pdf = (await client.files.create_from_paths([pdf_resource]))[0]
180+
uploaded_profile = (await client.files.create_from_paths([profile_resource]))[0]
177181
response = await client.convert_colors(
178-
uploaded_pdf_for_color_conversion,
179-
color_profile=uploaded_custom_profile_for_color_conversion,
182+
uploaded_pdf,
183+
color_profile=uploaded_profile,
180184
)
181185

182186
assert response.output_files
@@ -185,8 +189,8 @@ async def test_live_async_convert_colors_custom_profile_success(
185189
assert output_file.size > 0
186190
assert response.warning is None
187191
input_ids = {str(file_id) for file_id in response.input_ids}
188-
assert str(uploaded_pdf_for_color_conversion.id) in input_ids
189-
assert str(uploaded_custom_profile_for_color_conversion.id) in input_ids
192+
assert str(uploaded_pdf.id) in input_ids
193+
assert str(uploaded_profile.id) in input_ids
190194

191195

192196
@pytest.mark.asyncio

0 commit comments

Comments
 (0)