Ensure string values within text_object string

Assisted-by: Codex

Author: datalogics-cgreen

src/pdfrest/models/_internal.py

@@ -148,8 +148,22 @@ def _serialize_redactions(value: list[_PdfRedactionVariant]) -> str:
     return json.dumps(payload, separators=(",", ":"))
 
 
+def _serialize_text_object_value(value: Any) -> Any:
+    if isinstance(value, str):
+        return value
+    return json.dumps(value, separators=(",", ":"))
+
+
 def _serialize_text_objects(value: list[BaseModel]) -> str:
-    payload = [entry.model_dump(mode="json", exclude_none=True) for entry in value]
+    payload = [
+        {
+            key: _serialize_text_object_value(field_value)
+            for key, field_value in entry.model_dump(
+                mode="json", exclude_none=True
+            ).items()
+        }
+        for entry in value
+    ]
     return json.dumps(payload, separators=(",", ":"))
 
 

tests/live/test_live_add_text_to_pdf.py

@@ -42,12 +42,22 @@ def _serialize_text_object_for_extra_body(
     text_object: dict[str, object],
 ) -> dict[str, object]:
     serialized = dict(text_object)
+    # PdfAddTextObjectModel coercion: numeric placement/size fields are floats on
+    # serialization even when callers provide integers.
+    for key in ("max_width", "rotation", "text_size", "x", "y"):
+        value = serialized.get(key)
+        if isinstance(value, int):
+            serialized[key] = float(value)
     rgb = serialized.get("text_color_rgb")
     if isinstance(rgb, (list, tuple)):
         serialized["text_color_rgb"] = ",".join(str(channel) for channel in rgb)
     cmyk = serialized.get("text_color_cmyk")
     if isinstance(cmyk, (list, tuple)):
         serialized["text_color_cmyk"] = ",".join(str(channel) for channel in cmyk)
+    # Match add-text wire format where each non-string value is JSON-quoted.
+    for key, value in list(serialized.items()):
+        if not isinstance(value, str):
+            serialized[key] = json.dumps(value, separators=(",", ":"))
     return serialized
 
 

tests/test_add_text_to_pdf.py

@@ -39,6 +39,8 @@ def _serialize_text_object_for_request(
     text_object: dict[str, object],
 ) -> dict[str, object]:
     serialized = dict(text_object)
+    # PdfAddTextObjectModel defines these fields as floats, so Pydantic serializes
+    # integer inputs as 200.0/45.0/etc. Mirror that to keep wire assertions exact.
     for key in ("max_width", "rotation", "text_size", "x", "y"):
         value = serialized.get(key)
         if isinstance(value, int):
@@ -49,6 +51,10 @@ def _serialize_text_object_for_request(
     cmyk = serialized.get("text_color_cmyk")
     if isinstance(cmyk, (list, tuple)):
         serialized["text_color_cmyk"] = ",".join(str(channel) for channel in cmyk)
+    # Add-text payloads now quote non-string values inside the text_objects JSON.
+    for key, value in list(serialized.items()):
+        if not isinstance(value, str):
+            serialized[key] = json.dumps(value, separators=(",", ":"))
     return serialized