WIP: two small fixes in Server and Account#36
Conversation
…registration may have been skipped
…mes unit testable
| - ./data/db:/opt/solid/db | ||
| - ./data/pods:/opt/solid/pods | ||
| - ./data/profiles:/opt/solid/profiles | ||
| - ./frontend:/opt/solid/frontend |
There was a problem hiding this comment.
This is a developer thing, but should not be in the default docker compose. Only the data (and maybe config) should persist to the host by default
There was a problem hiding this comment.
This one can be removed - there is already a script for this in the testsuite directory that can be reused, it already creates the 'alice' and 'bob' accounts.
There was a problem hiding this comment.
Why is this file split up? This change is adding a layer of indirection I think we don't need to add. This change reduces the file to a glue layer, but we already have a glue layer www directory.
There was a problem hiding this comment.
This is so that I can write unit tests for the SolidStorageHandler, which accepts request/response objects. This avoids adding complex mocks/stubs.
There was a problem hiding this comment.
Looking at the www directory, would it be a good idea to move the construction of the request/response objects there, and pass them to all the separate route handlers? That fixes the problem without adding another layer.
poef
changed the title
2 participants
No description provided.