Discord RPC artist name fixed#4311
Open
TwixierDev wants to merge 1 commit into
Open
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
121
to
123
| state: sanitizeActivityText( | ||
| songInfo.tags?.at(0) ?? songInfo.artist | ||
| songInfo.artist ?? songInfo.tags?.at(0) | ||
| ), // Artist name |
Contributor
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ⏎········songInfo.artist·??·songInfo.tags?.at(0)·⏎······ with songInfo.artist·??·songInfo.tags?.at(0)
Suggested change
| state: sanitizeActivityText( | |
| songInfo.tags?.at(0) ?? songInfo.artist | |
| songInfo.artist ?? songInfo.tags?.at(0) | |
| ), // Artist name | |
| state: sanitizeActivityText(songInfo.artist ?? songInfo.tags?.at(0)), // Artist name |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code
songInfo.tags?.at(0)indiscord-service.ts 122:9was retrieving the first tag of the video instead of finding the artist name, and if it couldn't find it, it was returning thesongInfo.artistcode.When I rearranged the code in the opposite way, it now does the same thing for the
songInfo.artistcode. I've shown the before and after below.