Skip to content

Minor Cleanups #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michaeljguarino wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Minor Cleanups #193

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6be676c
add Goth.start and cleanup error handling to avoid unnecessary crashes
michaeljguarino Nov 6, 2024
4958159
shutdown process if cannot retry
michaeljguarino Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions lib/goth.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,18 @@ defmodule Goth do
GenServer.start_link(__MODULE__, opts, name: registry_name(name))
end

def start(opts) do
opts =
opts
|> Keyword.put_new(:refresh_before, @refresh_before_minutes * 60)
|> Keyword.put_new(:http_client, {:finch, []})
|> Keyword.put_new(:source, {:default, []})
|> Keyword.put_new(:retry_delay, &exp_backoff/1)

name = Keyword.fetch!(opts, :name)
GenServer.start(__MODULE__, opts, name: registry_name(name))
end

def __finch__(options) do
{method, options} = Keyword.pop!(options, :method)
{url, options} = Keyword.pop!(options, :url)
Expand Down Expand Up @@ -246,8 +258,9 @@ defmodule Goth do
end
end

defp handle_retry(exception, %{retries: retries, max_retries: max_retries}) when retries >= max_retries - 1 do
raise "too many failed attempts to refresh, last error: #{inspect(exception)}"
defp handle_retry(exception, %{retries: retries, max_retries: max_retries} = state) when retries >= max_retries - 1 do
Logger.error("too many failed attempts to refresh, last error: #{inspect(exception)}")
{:stop, {:shutdown, exception}, %{state | retries: 0}}
end

defp handle_retry(_, state) do
Expand Down