Created a PR to Support Redis for message passing between client#195
Created a PR to Support Redis for message passing between client#195chattes wants to merge 18 commits into
Conversation
|
I myself am in need of this feature as well. Perhaps it is however better to abstract the redis portion, to allow for different backends such as memcache. Also there's quite a few console logs left. |
|
yeah i will remove the console.log. Let me check how we can abstract the Radis part away. Thanks |
afrokick
left a comment
afrokick
left a comment
There was a problem hiding this comment.
Why files permissions was changed?
| } | ||
| cert: "", | ||
| }, | ||
| redis: false, |
There was a problem hiding this comment.
i'd rather suggest to use an object to describe redis config:
redis: {
host: "",
port: 0,
}
| import { IRealm } from "../../models/realm"; | ||
| import { MyWebSocket } from "./webSocket"; | ||
|
|
||
| const Redis = require("ioredis"); |
|
Like @KaiserKarel said, we should use an abstraction to transfer/handle messages. I have an idea how to do it. I suggest to move this PR to separate package to extends peerjs server with Redis. Others stuff like RabbitMQ, Memcache etc also should be separated packages. |
|
Hey just wondering if there are any updates on this PR? would be intersted to try it out |
|
THIS PROJECT SEEMS COOL THX |
5 participants
Ability to use Redis Pub Sub to pass messaged between webrtc clients connected across mutiple servers.