review(gitops): drop duplicate-return branches in redeploy error paths

The if/else after a non-nil error did `return result, err` in both
branches; only the side-effect (markSyncRedeployFailedInternal) was
gated on the AsType check. Flatten to do the gated side-effect and
return once.

For the directory-sync path: the source (redeployIfRunningAfterSync)
only ever returns nil or redeployAfterSyncFailedError, so the AsType
check is effectively guaranteed today but is left as a defensive
guard against future contract drift.

For the single-file path: the source (getOrCreateProjectInternal)
can return either the typed error or a plain failSync error, so the
AsType check is meaningful — but the duplicate return still wasn't.

Greptile review on getarcaneapp#2782.

Author: peitschie

backend/internal/services/gitops_sync_service.go

@@ -962,9 +962,10 @@ func (s *GitOpsSyncService) performDirectorySync(ctx context.Context, sync *mode
 
 	if contentsChanged {
 		if redeployErr := s.redeployIfRunningAfterSync(ctx, project, actor, "directory"); redeployErr != nil {
+			// redeployIfRunningAfterSync only ever returns redeployAfterSyncFailedError;
+			// AsType remains as a defensive guard against future contract drift.
 			if typed, ok := errors.AsType[redeployAfterSyncFailedError](redeployErr); ok {
 				s.markSyncRedeployFailedInternal(ctx, sync, id, source.commitHash, syncedFiles, typed, actor, result)
-				return result, redeployErr
 			}
 			return result, redeployErr
 		}
@@ -985,10 +986,13 @@ func (s *GitOpsSyncService) performSingleFileSyncInternal(ctx context.Context, s
 
 	project, err := s.getOrCreateProjectInternal(ctx, sync, id, source.composeContent, source.envContent, result, actor)
 	if err != nil {
+		// err may be a redeployAfterSyncFailedError (from updateProjectForSyncInternal)
+		// or a plain failSync error (from CreateProject / ApplyGitSyncProjectFiles).
+		// Only the typed case warrants the redeploy-failure marker; the rest just
+		// surface through the caller.
 		if redeployErr, ok := errors.AsType[redeployAfterSyncFailedError](err); ok {
 			syncedFiles := []string{filepath.Base(sync.ComposePath)}
 			s.markSyncRedeployFailedInternal(ctx, sync, id, source.commitHash, syncedFiles, redeployErr, actor, result)
-			return result, err
 		}
 		return result, err
 	}