Fix missing index on activity_log_id in activity_log_subjects table#2418
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds a migration that indexes ChangesActivity log subject indexing
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@database/migrations/2026_06_25_175747_add_index_to_activity_log_subjects_table.php`:
- Around line 15-20: Remove the PostgreSQL-specific early return from the
migration so the index is created for all supported drivers; in the migration
class that contains the up/down logic for adding the activity log subjects
index, delete the DB::getDriverName() guard and its paired skip in the rollback
path so the schema change always applies consistently.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: bc3ef64d-4fc6-4807-a829-b8c83e674600
📒 Files selected for processing (1)
database/migrations/2026_06_25_175747_add_index_to_activity_log_subjects_table.php
As mentioned by coderabbit. Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
|
@coderabbitai full-review |
|
✅ Action performedFull review finished. |
Closes #2355