fix: code style and remaining PHPStan issues

Pint style fixes:
- Fix import ordering in DocumentsRelationManager and DocumentResource
- Convert double quotes to single quotes in migration
- Fix brace position in anonymous class
- Use single line empty body for boot method

PHPStan fixes:
- Add array value type to forTypes @method annotation
- Use empty() instead of === null for slug check
- Remove unnecessary null return type from closure

Author: gavinmcfall

server-documentation/database/migrations/2024_01_01_000004_update_documents_type_column.php

@@ -4,8 +4,7 @@
 use Illuminate\Support\Facades\DB;
 use Illuminate\Support\Facades\Schema;
 
-return new class extends Migration
-{
+return new class extends Migration {
     public function up(): void
     {
         $driver = Schema::getConnection()->getDriverName();
@@ -15,11 +14,11 @@ public function up(): void
             // SQLite doesn't support ALTER COLUMN, but it also doesn't enforce enum types
             // The column will accept any value, so we just need to update the data
         } elseif ($driver === 'mysql' || $driver === 'mariadb') {
-            DB::statement("ALTER TABLE documents MODIFY COLUMN type VARCHAR(50) NOT NULL DEFAULT 'player'");
+            DB::statement('ALTER TABLE documents MODIFY COLUMN type VARCHAR(50) NOT NULL DEFAULT \'player\'');
         } elseif ($driver === 'pgsql') {
             // PostgreSQL: drop the enum constraint and change to varchar
-            DB::statement("ALTER TABLE documents ALTER COLUMN type TYPE VARCHAR(50)");
-            DB::statement("ALTER TABLE documents ALTER COLUMN type SET DEFAULT 'player'");
+            DB::statement('ALTER TABLE documents ALTER COLUMN type TYPE VARCHAR(50)');
+            DB::statement('ALTER TABLE documents ALTER COLUMN type SET DEFAULT \'player\'');
         }
 
         // Migrate old 'admin' type to 'server_admin' for all drivers
@@ -36,7 +35,7 @@ public function down(): void
 
         // Change back to enum (MySQL only - other drivers will just have varchar)
         if ($driver === 'mysql' || $driver === 'mariadb') {
-            DB::statement("ALTER TABLE documents MODIFY COLUMN type ENUM('admin', 'player') NOT NULL DEFAULT 'player'");
+            DB::statement('ALTER TABLE documents MODIFY COLUMN type ENUM(\'admin\', \'player\') NOT NULL DEFAULT \'player\'');
         }
     }
 };

server-documentation/src/Filament/Admin/RelationManagers/DocumentsRelationManager.php

@@ -4,13 +4,13 @@
 
 namespace Starter\ServerDocumentation\Filament\Admin\RelationManagers;
 
-use Filament\Forms\Components\TextInput;
-use Filament\Resources\RelationManagers\RelationManager;
 use Filament\Actions\AttachAction;
 use Filament\Actions\CreateAction;
 use Filament\Actions\DetachAction;
 use Filament\Actions\DetachBulkAction;
 use Filament\Actions\ViewAction;
+use Filament\Forms\Components\TextInput;
+use Filament\Resources\RelationManagers\RelationManager;
 use Filament\Tables\Columns\TextColumn;
 use Filament\Tables\Table;
 use Starter\ServerDocumentation\Filament\Admin\Resources\DocumentResource;

server-documentation/src/Filament/Admin/Resources/DocumentResource.php

@@ -4,12 +4,14 @@
 
 namespace Starter\ServerDocumentation\Filament\Admin\Resources;
 
+use App\Models\Egg;
+use App\Models\Server;
 use App\Traits\Filament\CanCustomizePages;
 use App\Traits\Filament\CanCustomizeRelations;
 use App\Traits\Filament\CanModifyForm;
 use App\Traits\Filament\CanModifyTable;
-use App\Models\Egg;
-use App\Models\Server;
+use Filament\Actions\DeleteBulkAction;
+use Filament\Actions\EditAction;
 use Filament\Forms\Components\CheckboxList;
 use Filament\Forms\Components\Placeholder;
 use Filament\Forms\Components\RichEditor;
@@ -20,8 +22,6 @@
 use Filament\Resources\Resource;
 use Filament\Schemas\Components\Section;
 use Filament\Schemas\Schema;
-use Filament\Actions\DeleteBulkAction;
-use Filament\Actions\EditAction;
 use Filament\Tables\Columns\TextColumn;
 use Filament\Tables\Filters\TrashedFilter;
 use Filament\Tables\Table;

server-documentation/src/Models/Document.php

@@ -39,7 +39,7 @@
  * @property-read \Illuminate\Database\Eloquent\Collection<int, DocumentVersion> $versions
  *
  * @method static Builder|Document forServer(Server $server)
- * @method static Builder|Document forTypes(array $types)
+ * @method static Builder|Document forTypes(array<string> $types)
  * @method static Builder|Document published()
  * @method static Builder|Document global()
  * @method static Builder|Document search(string $term)
@@ -114,7 +114,7 @@ protected static function booted(): void
     {
         static::creating(function (Document $document) {
             $document->uuid ??= Str::uuid()->toString();
-            if ($document->slug === null) {
+            if (empty($document->slug)) {
                 $document->slug = static::generateUniqueSlug($document->title);
             }
             if ($document->author_id === null && auth()->check()) {

server-documentation/src/ServerDocumentationPlugin.php

@@ -36,7 +36,5 @@ public function register(Panel $panel): void
         }
     }
 
-    public function boot(Panel $panel): void
-    {
-    }
+    public function boot(Panel $panel): void {}
 }

server-documentation/src/Services/DocumentService.php

@@ -191,9 +191,9 @@ public function createVersionFromOriginal(
         ?string $originalContent,
         ?string $changeSummary = null,
         ?int $userId = null
-    ): ?DocumentVersion {
-        /** @var DocumentVersion|null */
-        return DB::transaction(function () use ($document, $originalTitle, $originalContent, $changeSummary, $userId): ?DocumentVersion {
+    ): DocumentVersion {
+        /** @var DocumentVersion */
+        return DB::transaction(function () use ($document, $originalTitle, $originalContent, $changeSummary, $userId): DocumentVersion {
             /** @var DocumentVersion|null $latestVersion */
             $latestVersion = $document->versions()
                 ->lockForUpdate()