fix(player-counter): use null as sentinel for unsupported player lists

Author: szpolny

player-counter/src/Extensions/Query/Schemas/CitizenFXQueryTypeSchema.php

@@ -18,7 +18,7 @@ public function getName(): string
         return 'CitizenFX';
     }
 
-    /** @return ?array{hostname: string, map: string, current_players: int, max_players: int, players: array<array{id: string, name: string}>} */
+    /** @return ?array{hostname: string, map: string, current_players: int, max_players: int, players: ?array<array{id: string, name: string}>} */
     public function process(string $ip, int $port): ?array
     {
         try {

player-counter/src/Extensions/Query/Schemas/GoldSourceQueryTypeSchema.php

@@ -16,7 +16,7 @@ public function getName(): string
         return 'GoldSrc';
     }
 
-    /** @return ?array{hostname: string, map: string, current_players: int, max_players: int, players: array<array{id: string, name: string}>} */
+    /** @return ?array{hostname: string, map: string, current_players: int, max_players: int, players: ?array<array{id: string, name: string}>} */
     public function process(string $ip, int $port): ?array
     {
         return $this->run($ip, $port, SourceQuery::GOLDSOURCE);

player-counter/src/Extensions/Query/Schemas/MinecraftJavaQueryTypeSchema.php

@@ -19,7 +19,7 @@ public function getName(): string
         return 'Minecraft (Java)';
     }
 
-    /** @return ?array{hostname: string, map: string, current_players: int, max_players: int, players: array<array{id: string, name: string}>} */
+    /** @return ?array{hostname: string, map: string, current_players: int, max_players: int, players: ?array<array{id: string, name: string}>} */
     public function process(string $ip, int $port): ?array
     {
         $query = $this->tryQuery($ip, $port);
@@ -41,7 +41,7 @@ public function process(string $ip, int $port): ?array
                 'map' => 'world', // No map from MinecraftPing
                 'current_players' => $data['players']['online'],
                 'max_players' => $data['players']['max'],
-                'players' => $data['players']['sample'] ?? [],
+                'players' => $data['players']['sample'] ?? null,
             ];
         } catch (Exception $exception) {
             report($exception);
@@ -54,7 +54,7 @@ public function process(string $ip, int $port): ?array
         return null;
     }
 
-    /** @return false|array{hostname: string, map: string, current_players: int, max_players: int, players: array<array{id: string, name: string}>} */
+    /** @return false|array{hostname: string, map: string, current_players: int, max_players: int, players: ?array<array{id: string, name: string}>} */
     protected function tryQuery(string $ip, int $port): false|array
     {
         $query = new MinecraftQuery();

player-counter/src/Extensions/Query/Schemas/SourceQueryTypeSchema.php

@@ -18,13 +18,13 @@ public function getName(): string
         return 'Source';
     }
 
-    /** @return ?array{hostname: string, map: string, current_players: int, max_players: int, players: array<array{id: string, name: string}>} */
+    /** @return ?array{hostname: string, map: string, current_players: int, max_players: int, players: ?array<array{id: string, name: string}>} */
     public function process(string $ip, int $port): ?array
     {
         return $this->run($ip, $port, SourceQuery::SOURCE);
     }
 
-    /** @return ?array{hostname: string, map: string, current_players: int, max_players: int, players: array<array{id: string, name: string}>} */
+    /** @return ?array{hostname: string, map: string, current_players: int, max_players: int, players: ?array<array{id: string, name: string}>} */
     protected function run(string $ip, int $port, int $engine): ?array
     {
         $query = new SourceQuery();
@@ -38,17 +38,17 @@ protected function run(string $ip, int $port, int $engine): ?array
                 return null;
             }
 
-            $players = $query->GetPlayers() ?: [];
+            $players = $query->GetPlayers();
 
             return [
                 'hostname' => (string) ($info['HostName'] ?? 'Unknown'),
                 'map' => (string) ($info['Map'] ?? 'Unknown'),
                 'current_players' => (int) ($info['Players'] ?? 0),
                 'max_players' => (int) ($info['MaxPlayers'] ?? 0),
-                'players' => array_map(fn ($player) => [
+                'players' => is_array($players) ? array_map(fn ($player) => [
                     'id' => (string) ($player['Id'] ?? ''),
                     'name' => (string) ($player['Name'] ?? 'Unknown'),
-                ], $players),
+                ], $players) : null,
             ];
         } catch (Exception $exception) {
             report($exception);