Fail when trying to edit a Directory like if it was File content (#78)

* Fail when trying to edit a `Directory` like if it was `File` content

* use error.Is for file does not exist and directory does not exist

* Use the same messages as in the asFilesystemError function

---------

Co-authored-by: Quinten <67589015+QuintenQVD0@users.noreply.github.com>

Author: rmartinoscar

router/router_server_files.go

@@ -37,10 +37,15 @@ func getServerFileContents(c *gin.Context) {
 	}
 	f, st, err := s.Filesystem().File(p)
 	if err != nil {
-		if strings.Contains(err.Error(), "file does not exist") {
+		if errors.Is(err, os.ErrNotExist) {
 			c.AbortWithStatusJSON(http.StatusNotFound, gin.H{
 				"error":      "The requested resources was not found on the system.",
 				"request_id": c.Writer.Header().Get("X-Request-Id")})
+		} else if strings.Contains(err.Error(), "filesystem: is a directory") {
+			c.AbortWithStatusJSON(http.StatusBadRequest, gin.H{
+				"error":      "Cannot perform that action: file is a directory.",
+				"request_id": c.Writer.Header().Get("X-Request-Id"),
+			})
 		} else {
 			middleware.CaptureAndAbort(c, err)
 		}
@@ -89,6 +94,13 @@ func getServerListDirectory(c *gin.Context) {
 	s := middleware.ExtractServer(c)
 	dir := c.Query("directory")
 	if stats, err := s.Filesystem().ListDirectory(dir); err != nil {
+		// If the error is that the folder does not exist return a 404.
+		if errors.Is(err, os.ErrNotExist) {
+			c.AbortWithStatusJSON(http.StatusNotFound, gin.H{
+				"error": "The requested directory was not found on the server.",
+			})
+			return
+		}
 		middleware.CaptureAndAbort(c, err)
 	} else {
 		c.JSON(http.StatusOK, stats)

server/filesystem/filesystem.go

@@ -82,6 +82,9 @@ func (fs *Filesystem) File(p string) (ufs.File, Stat, error) {
 		_ = f.Close()
 		return nil, Stat{}, err
 	}
+	if st.IsDir() {
+		return f, Stat{}, errors.New("filesystem: is a directory")
+	}
 	return f, st, nil
 }