clippy: fix enum_glob_use lint

[xtqqczze]

https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#enum_glob_use

[davidv1992]

Hmm, I think this is one where we should make the decision to not include it in the big list. I'm not sure I like the impact this one has on our code base.

[xtqqczze]

I think that the lint’s suggested fix should favor using the fully qualified enumeration variant name instead of importing the variants into scope, see rust-lang/rust-clippy#16900.

[codecov]

Codecov Report

❌ Patch coverage is 63.04348% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.48%. Comparing base (04e5f61) to head (fd8b0be).
⚠️ Report is 90 commits behind head on main.

Files with missing lines	Patch %	Lines
ntp-proto/src/packet/extension_fields.rs	68.96%	9 Missing ⚠️
ntp-proto/src/packet/error.rs	46.15%	7 Missing ⚠️
ntp-proto/src/source.rs	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2240      +/-   ##
==========================================
- Coverage   83.59%   83.48%   -0.12%     
==========================================
  Files          93       94       +1     
  Lines       21644    21669      +25     
==========================================
- Hits        18094    18091       -3     
- Misses       3550     3578      +28     

Flag	Coverage Δ
fuzz-cookie_parsing_sound	0.40% <0.00%> (-0.01%)	⬇️
fuzz-duration_from_float	0.27% <0.00%> (-0.01%)	⬇️
fuzz-encrypted_client_parsing	7.05% <19.56%> (-0.15%)	⬇️
fuzz-encrypted_server_parsing	9.77% <10.86%> (+0.06%)	⬆️
fuzz-handle	13.24% <10.86%> (-0.89%)	⬇️
fuzz-ipfilter	2.53% <0.00%> (-0.01%)	⬇️
fuzz-key_exchange_request_parsing	3.83% <0.00%> (-0.06%)	⬇️
fuzz-key_exchange_response_parsing	3.73% <0.00%> (-0.03%)	⬇️
fuzz-packet_keyset	5.72% <6.52%> (+0.05%)	⬆️
fuzz-packet_parsing_sound	6.17% <6.52%> (-1.92%)	⬇️
fuzz-ptp_message_parsing	62.27% <ø> (-0.67%)	⬇️
fuzz-record_encode_decode	4.50% <0.00%> (-0.01%)	⬇️
test-aarch64-apple-darwin	82.46% <58.69%> (-0.07%)	⬇️
test-x86_64-unknown-linux-gnu	82.38% <58.69%> (-0.06%)	⬇️
test-x86_64-unknown-linux-musl	82.38% <58.69%> (-0.06%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[davidv1992]

@xtqqczze I didn't realize you had already made the changeover to the other type of fix. This way indeed looks much better and I would like to merge this. Are there reasons you still kept it as draft?