feat(lint): add shellcheck for shell script verification

Author: lynnwallenstein

.devcontainer/Dockerfile

@@ -1,8 +1,8 @@
 FROM mcr.microsoft.com/devcontainers/base:bookworm
 
 # [Optional] Uncomment this section to install additional OS packages.
-# RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \
-#     && apt-get -y install --no-install-recommends <your-package-list-here>
+RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \
+    && apt-get -y install --no-install-recommends shellcheck
 
 # [Optional] Uncomment if you want to install an additional version of node using nvm
 # ARG EXTRA_NODE_VERSION=10

.github/workflows/shellcheck.yml

@@ -0,0 +1,18 @@
+name: Shell Script Linting
+
+on:
+  push:
+    branches: [ main, booting ]
+  pull_request:
+    branches: [ main ]
+
+jobs:
+  shellcheck:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Run shellcheck
+        run: |
+          shellcheck install.sh .devcontainer/*.sh scripts/*.sh templates/scripts/*.sh

Makefile

@@ -23,7 +23,9 @@ build: ## Create a production build
 	@echo "Build target not implemented yet — update after choosing your tech stack"
 
 lint: ## Run code formatting & linting
-	@echo "Lint target not implemented yet — update after choosing your tech stack"
+	@echo "🔍 Linting shell scripts..."
+	@shellcheck install.sh .devcontainer/*.sh scripts/*.sh templates/scripts/*.sh || (echo "❌ Shellcheck failed. Fix errors above." && exit 1)
+	@echo "✅ Shell scripts linted."
 
 clean: ## Remove build artifacts
 	@echo "Clean target not implemented yet — update after choosing your tech stack"

scripts/setup-env.sh

@@ -13,19 +13,19 @@ if [ ! -f .env ]; then
 fi
 
 echo "Setting up environment variables..."
-read -p "Enter your Git Name: " GIT_NAME
-read -p "Enter your Git Email: " GIT_EMAIL
+read -rp "Enter your Git Name: " GIT_NAME
+read -rp "Enter your Git Email: " GIT_EMAIL
 
 echo ""
 echo "Optional: SSH Public Key for commit signing."
 echo "If you use 1Password as your SSH agent, you can copy the public key string directly."
 echo "(e.g., ssh-ed25519 AAAAC3Nz...)"
-read -p "Enter your SSH Public Key (press Enter to skip): " SSH_PUBLIC_KEY
+read -rp "Enter your SSH Public Key (press Enter to skip): " SSH_PUBLIC_KEY
 
 echo ""
 echo "Optional: The Gemini API Key is used by the Gemini CLI inside this Devcontainer."
 echo "You can get an API key from: https://aistudio.google.com/app/apikey"
-read -p "Enter your Gemini API Key (press Enter to skip): " GEMINI_API_KEY
+read -rp "Enter your Gemini API Key (press Enter to skip): " GEMINI_API_KEY
 
 echo ""
 echo "Optional: Authenticate with GitHub CLI for automations inside the Devcontainer."

scripts/troubleshooting.sh

@@ -5,7 +5,7 @@ echo "🔍 Starting Devcontainer Troubleshooting..."
 echo "----------------------------------------"
 
 # Change to the repository root relative to the script's location
-cd "$(dirname "${BASH_SOURCE[0]}")/.."
+cd "$(dirname "${BASH_SOURCE[0]}")/.." || exit
 
 ISSUE_FOUND=0
 

templates/scripts/setup-env.sh

@@ -13,19 +13,19 @@ if [ ! -f .env ]; then
 fi
 
 echo "Setting up environment variables..."
-read -p "Enter your Git Name: " GIT_NAME
-read -p "Enter your Git Email: " GIT_EMAIL
+read -rp "Enter your Git Name: " GIT_NAME
+read -rp "Enter your Git Email: " GIT_EMAIL
 
 echo ""
 echo "Optional: SSH Public Key for commit signing."
 echo "If you use 1Password as your SSH agent, you can copy the public key string directly."
 echo "(e.g., ssh-ed25519 AAAAC3Nz...)"
-read -p "Enter your SSH Public Key (press Enter to skip): " SSH_PUBLIC_KEY
+read -rp "Enter your SSH Public Key (press Enter to skip): " SSH_PUBLIC_KEY
 
 echo ""
 echo "Optional: The Gemini API Key is used by the Gemini CLI inside this Devcontainer."
 echo "You can get an API key from: https://aistudio.google.com/app/apikey"
-read -p "Enter your Gemini API Key (press Enter to skip): " GEMINI_API_KEY
+read -rp "Enter your Gemini API Key (press Enter to skip): " GEMINI_API_KEY
 
 echo ""
 echo "Optional: Authenticate with GitHub CLI for automations inside the Devcontainer."

templates/scripts/troubleshooting.sh

@@ -5,7 +5,7 @@ echo "🔍 Starting Devcontainer Troubleshooting..."
 echo "----------------------------------------"
 
 # Change to the repository root relative to the script's location
-cd "$(dirname "${BASH_SOURCE[0]}")/.."
+cd "$(dirname "${BASH_SOURCE[0]}")/.." || exit
 
 ISSUE_FOUND=0