Skip to content

PBM-843 Improve error handling for inMemory storage engine #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Anuja888 wants to merge 1 commit into
base: dev
Choose a base branch
from
+11 −5
Open

PBM-843 Improve error handling for inMemory storage engine #1269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions pbm/backup/physical.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,17 @@ func (bc *BackupCursor) create(ctx context.Context, retry int) (*mongo.Cursor, e
cur, err := bc.conn.Database("admin").Aggregate(ctx, mongo.Pipeline{
{{"$backupCursor", opts}},
})
if err != nil {
se, ok := err.(mongo.ServerError) //nolint:errorlint
if !ok {
return nil, err
}
if err != nil {
// Detect inMemory engine unsupported backupCursor
if strings.Contains(err.Error(), "$backupCursor") {
Copy link
Copy Markdown
Collaborator

@jcechace jcechace Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is extremely brittle and potentially dangerous -- it's quite generic so it could swallow the later checks.

return nil, errors.New("physical backup is not supported for the inMemory storage engine")
}

se, ok := err.(mongo.ServerError)
if !ok {
return nil, err
}

Comment on lines +97 to +107
Copy link
Copy Markdown
Collaborator

@jcechace jcechace Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like formatting was broken by mistake.

Easy fix by running go fmt ./... from project root


retryableErr := false
if se.HasErrorCode(openConflictWithCheckpointErrCode) {
Expand Down
Loading