Bump mongo-go-driver: v1.17.9 -> v2.6.0#1314
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
boris-ilijic
force-pushed
the
PBM-1592-bump-go-driver
branch
from
df96cee to
36a5792
Compare
Additionally bump mongo-tools dependency.
boris-ilijic
force-pushed
the
PBM-1592-bump-go-driver
branch
from
36a5792 to
7f9ca88
Compare
... the server In v1.x mongo-driver returns: "socket was unexpectedly closed", while in v2.6 it returns "connection closed unexpectedly by the other side".
boris-ilijic
force-pushed
the
PBM-1592-bump-go-driver
branch
from
7f9ca88 to
3cf04d6
Compare
boris-ilijic
force-pushed
the
PBM-1592-bump-go-driver
branch
from
4392686 to
de4bcbf
Compare
jcechace
left a comment
jcechace
left a comment
There was a problem hiding this comment.
LGTM. Left few questions, mostly just out of curiosity.
| if wc := l.options.WriteConcern; wc != nil && wc.W != nil { | ||
| cmd = append(cmd, bson.E{ | ||
| Key: "writeConcern", | ||
| Value: bson.D{{Key: "w", Value: wc.W}}, | ||
| }) |
There was a problem hiding this comment.
Is this intentionally ignoring ignoring wc.Journal?
There was a problem hiding this comment.
This is not connection object, this is create command that also has writeConcern property.
See here: https://www.mongodb.com/docs/manual/reference/command/create/#syntax
So j is not relevant here.
| // migration mongo-driver v1->v2: fix this in PBM-1682 | ||
| CRC: uint64(ns.CRC), //nolint:gosec |
There was a problem hiding this comment.
Just for information. What needs to be fixed here? On binary level this should be safe and it looks like we are using crc64.ECMA for CRC calculations.
There was a problem hiding this comment.
I'll double check as part of PBM-1682
| // migration mongo-driver v1->v2: fix this in PBM-1682 | ||
| // op.Hash = txnOp.Hash |
There was a problem hiding this comment.
Just for info. What are the implications of dropping this? Seems that field was last useful in MongoDB 4.0
There was a problem hiding this comment.
Yes, agree, this is obsolete but I'll double check impact.
2 participants
PR for https://perconadev.atlassian.net/browse/PBM-1592
PR migrates from go.mongodb.org/mongo-driver v1 to v2 (v2.6.0) and bumps the related
mongo-toolsdependency to latest.Follow up tasks related
mongo-toolswill be part of: https://perconadev.atlassian.net/browse/PBM-1682.