Skip to content

fix(pmm): set gRPC service to ClusterIP to avoid duplicate nodePort conflict#862

Open
somaz94 wants to merge 1 commit into
percona:mainfrom
somaz94:fix/pmm-grpc-service-nodeport-conflict
Open

fix(pmm): set gRPC service to ClusterIP to avoid duplicate nodePort conflict#862
somaz94 wants to merge 1 commit into
percona:mainfrom
somaz94:fix/pmm-grpc-service-nodeport-conflict

Conversation

@somaz94

@somaz94 somaz94 commented Jun 4, 2026

Copy link
Copy Markdown

The -grpc service created when ingress.enabled=true inherited the main
service.type. With service.type: NodePort and explicit
service.ports[].nodePort values, both monitoring-service and
monitoring-service-grpc requested the same nodePorts, so the second service
failed to deploy (a nodePort can only be claimed by one service).

The -grpc service is only referenced as an internal Ingress backend (see
templates/ingress.yaml), so it never needs to be NodePort/LoadBalancer. This
sets it to ClusterIP and drops the nodePort field from its ports, which also
avoids a redundant second LoadBalancer when service.type: LoadBalancer.

Validation (helm template, chart pmm-1.8.1):

  • Default (ingress disabled): only monitoring-service rendered, unchanged.
  • NodePort + explicit nodePort + ingress enabled: monitoring-service keeps its
    nodePorts; monitoring-service-grpc renders as ClusterIP with no nodePort — no conflict.
  • service.type=ClusterIP + ingress enabled: both ClusterIP, unchanged.
  • helm lint and ct lint pass.

closes: #723


Drafted with Claude Code (Opus 4.8) and manually reviewed.

@it-percona-cla

it-percona-cla commented Jun 4, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@somaz94
somaz94 marked this pull request as ready for review June 4, 2026 06:54
@somaz94
somaz94 requested a review from a team as a code owner June 4, 2026 06:54
@somaz94
somaz94 requested review from ademidoff and maxkondr and removed request for a team June 4, 2026 06:54
@somaz94

somaz94 commented Jun 5, 2026

Copy link
Copy Markdown
Author

Gentle ping 🙏 — green and ready for review. This sets the PMM gRPC service to ClusterIP to avoid a duplicate NodePort allocation. Happy to address any feedback. Thanks!

@somaz94
somaz94 force-pushed the fix/pmm-grpc-service-nodeport-conflict branch from 9c5516a to e21a8a8 Compare July 8, 2026 03:29
@somaz94

somaz94 commented Jul 9, 2026

Copy link
Copy Markdown
Author

Friendly ping on this one — it's a small fix for the duplicate nodePort conflict on the PMM gRPC service, and CI is green. Anything I can adjust to help it get a review? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PMM Chart - monitoring-service-grpc1 duplicates nodePort values causing deployment failure

2 participants