fix(pmm): set gRPC service to ClusterIP to avoid duplicate nodePort conflict#862
Open
somaz94 wants to merge 1 commit into
Open
fix(pmm): set gRPC service to ClusterIP to avoid duplicate nodePort conflict#862somaz94 wants to merge 1 commit into
somaz94 wants to merge 1 commit into
Conversation
somaz94
marked this pull request as ready for review
June 4, 2026 06:54
somaz94
requested review from
ademidoff and
maxkondr
and removed request for
a team
June 4, 2026 06:54
Author
|
Gentle ping 🙏 — green and ready for review. This sets the PMM gRPC service to ClusterIP to avoid a duplicate NodePort allocation. Happy to address any feedback. Thanks! |
somaz94
force-pushed
the
fix/pmm-grpc-service-nodeport-conflict
branch
from
July 8, 2026 03:29
9c5516a to
e21a8a8
Compare
Author
|
Friendly ping on this one — it's a small fix for the duplicate nodePort conflict on the PMM gRPC service, and CI is green. Anything I can adjust to help it get a review? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
-grpcservice created wheningress.enabled=trueinherited the mainservice.type. Withservice.type: NodePortand explicitservice.ports[].nodePortvalues, bothmonitoring-serviceandmonitoring-service-grpcrequested the same nodePorts, so the second servicefailed to deploy (a nodePort can only be claimed by one service).
The
-grpcservice is only referenced as an internal Ingress backend (seetemplates/ingress.yaml), so it never needs to be NodePort/LoadBalancer. Thissets it to
ClusterIPand drops thenodePortfield from its ports, which alsoavoids a redundant second LoadBalancer when
service.type: LoadBalancer.Validation (helm template, chart pmm-1.8.1):
monitoring-servicerendered, unchanged.monitoring-servicekeeps itsnodePorts;
monitoring-service-grpcrenders as ClusterIP with no nodePort — no conflict.helm lintandct lintpass.closes: #723
Drafted with Claude Code (Opus 4.8) and manually reviewed.