fix errors and tests

Author: gkech

internal/pgbouncer/postgres_test.go

@@ -34,13 +34,13 @@ LANGUAGE SQL STABLE SECURITY DEFINER;`)
 func TestSQLAuthenticationQueryWithExposedSuperusers(t *testing.T) {
 	assert.Equal(t, sqlAuthenticationQuery("some.fn_name", true),
 		`CREATE OR REPLACE FUNCTION some.fn_name(username TEXT)
-RETURNS TABLE(username TEXT, password TEXT) AS '
+RETURNS TABLE(username TEXT, password TEXT) AS  E'
   SELECT rolname::TEXT, rolpassword::TEXT
   FROM pg_catalog.pg_authid
   WHERE pg_authid.rolname = $1
     AND pg_authid.rolcanlogin
     AND (NOT pg_authid.rolreplication OR pg_authid.rolname = ''postgres'')
-    AND pg_authid.rolname <> ''_crunchypgbouncer''
+    AND pg_authid.rolname <>  E''_crunchypgbouncer''
     AND (pg_authid.rolvaliduntil IS NULL OR pg_authid.rolvaliduntil >= CURRENT_TIMESTAMP)'
 LANGUAGE SQL STABLE SECURITY DEFINER;`)
 }
@@ -230,13 +230,13 @@ REVOKE ALL PRIVILEGES
  GRANT USAGE
     ON SCHEMA :"namespace" TO :"username";
 CREATE OR REPLACE FUNCTION :"namespace".get_auth(username TEXT)
-RETURNS TABLE(username TEXT, password TEXT) AS '
+RETURNS TABLE(username TEXT, password TEXT) AS  E'
   SELECT rolname::TEXT, rolpassword::TEXT
   FROM pg_catalog.pg_authid
   WHERE pg_authid.rolname = $1
     AND pg_authid.rolcanlogin
     AND (NOT pg_authid.rolreplication OR pg_authid.rolname = ''postgres'')
-    AND pg_authid.rolname <> ''_crunchypgbouncer''
+    AND pg_authid.rolname <>  E''_crunchypgbouncer''
     AND (pg_authid.rolvaliduntil IS NULL OR pg_authid.rolvaliduntil >= CURRENT_TIMESTAMP)'
 LANGUAGE SQL STABLE SECURITY DEFINER;
 REVOKE ALL PRIVILEGES

internal/pmm/hba.go

@@ -15,7 +15,7 @@ const (
 func PostgreSQLHBAs(inCluster *v1beta1.PostgresCluster, outHBAs *postgres.HBAs) {
 	// Limit the monitoring user to local connections using SCRAM.
 	outHBAs.Mandatory = append(outHBAs.Mandatory,
-		*postgres.NewHBA().TCP().User(MonitoringUser).Method("scram-sha-256").Network("127.0.0.0/8"),
-		*postgres.NewHBA().TCP().User(MonitoringUser).Method("scram-sha-256").Network("::1/128"),
-		*postgres.NewHBA().TCP().User(MonitoringUser).Method("reject"))
+		postgres.NewHBA().TCP().User(MonitoringUser).Method("scram-sha-256").Network("127.0.0.0/8"),
+		postgres.NewHBA().TCP().User(MonitoringUser).Method("scram-sha-256").Network("::1/128"),
+		postgres.NewHBA().TCP().User(MonitoringUser).Method("reject"))
 }