Skip to content

Commit 3cdef59

Browse files
committed
fix tests
1 parent 450c5ad commit 3cdef59

2 files changed

Lines changed: 6 additions & 13 deletions

File tree

internal/controller/postgrescluster/pgbackrest.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2491,6 +2491,8 @@ func (r *Reconciler) reconcileManualBackup(ctx context.Context,
24912491
})
24922492
backupJob.ObjectMeta.Labels = labels
24932493
backupJob.ObjectMeta.Annotations = annotations
2494+
// K8SPG-703
2495+
backupJob.ObjectMeta.Finalizers = []string{pNaming.FinalizerKeepJob}
24942496

24952497
// K8SPG-613
24962498
initImage, err := k8s.InitImage(ctx, r.Client, postgresCluster, &postgresCluster.Spec.Backups.PGBackRest)

percona/controller/pgbackup/controller.go

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -219,18 +219,6 @@ func (r *PGBackupReconciler) Reconcile(ctx context.Context, request reconcile.Re
219219
return reconcile.Result{}, errors.Wrap(err, "update PGBackup")
220220
}
221221

222-
if err := retry.RetryOnConflict(retry.DefaultBackoff, func() error {
223-
j := new(batchv1.Job)
224-
if err := r.Client.Get(ctx, client.ObjectKeyFromObject(job), j); err != nil {
225-
return errors.Wrap(err, "get job")
226-
}
227-
j.Finalizers = append(j.Finalizers, pNaming.FinalizerKeepJob)
228-
229-
return r.Client.Update(ctx, j)
230-
}); err != nil {
231-
return reconcile.Result{}, errors.Wrap(err, "update PGBackup status")
232-
}
233-
234222
if err := updateStatus(ctx, r.Client, pgBackup, func(bcp *v2.PerconaPGBackup) {
235223
bcp.Status.State = v2.BackupRunning
236224
bcp.Status.JobName = job.Name
@@ -673,7 +661,10 @@ func startBackup(ctx context.Context, c client.Client, pb *v2.PerconaPGBackup) e
673661
}
674662

675663
func findBackupJob(ctx context.Context, c client.Client, pb *v2.PerconaPGBackup) (*batchv1.Job, error) {
676-
if jobName := pb.GetAnnotations()[pNaming.AnnotationPGBackrestBackupJobName]; jobName != "" {
664+
if jobName := pb.GetAnnotations()[pNaming.AnnotationPGBackrestBackupJobName]; jobName != "" || pb.Status.JobName != "" {
665+
if jobName == "" {
666+
jobName = pb.Status.JobName
667+
}
677668
job := new(batchv1.Job)
678669
err := c.Get(ctx, types.NamespacedName{Name: jobName, Namespace: pb.Namespace}, job)
679670
if err != nil {

0 commit comments

Comments
 (0)