Skip to content

Commit 79d8f35

Browse files
authored
K8SPG-982: set pg_stat_statements by default (#1527)
https://perconadev.atlassian.net/browse/K8SPG-982
1 parent 8b4be5d commit 79d8f35

13 files changed

+68
-26
lines changed

build/crd/percona/generated/pgv2.percona.com_perconapgclusters.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22333,7 +22333,7 @@ spec:
2233322333
postgresParams:
2233422334
type: string
2233522335
querySource:
22336-
default: pgstatmonitor
22336+
default: pgstatstatements
2233722337
enum:
2233822338
- pgstatmonitor
2233922339
- pgstatstatements

config/crd/bases/pgv2.percona.com_perconapgclusters.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23028,7 +23028,7 @@ spec:
2302823028
postgresParams:
2302923029
type: string
2303023030
querySource:
23031-
default: pgstatmonitor
23031+
default: pgstatstatements
2303223032
enum:
2303323033
- pgstatmonitor
2303423034
- pgstatstatements

deploy/bundle.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23325,7 +23325,7 @@ spec:
2332523325
postgresParams:
2332623326
type: string
2332723327
querySource:
23328-
default: pgstatmonitor
23328+
default: pgstatstatements
2332923329
enum:
2333023330
- pgstatmonitor
2333123331
- pgstatstatements

deploy/crd.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23325,7 +23325,7 @@ spec:
2332523325
postgresParams:
2332623326
type: string
2332723327
querySource:
23328-
default: pgstatmonitor
23328+
default: pgstatstatements
2332923329
enum:
2333023330
- pgstatmonitor
2333123331
- pgstatstatements

deploy/cw-bundle.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23325,7 +23325,7 @@ spec:
2332523325
postgresParams:
2332623326
type: string
2332723327
querySource:
23328-
default: pgstatmonitor
23328+
default: pgstatstatements
2332923329
enum:
2333023330
- pgstatmonitor
2333123331
- pgstatstatements

e2e-tests/tests/monitoring-pmm3/06-check-pgstatstatements-query-source.yaml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,6 @@ commands:
77
88
source ../../functions
99
10-
kubectl -n ${NAMESPACE} patch perconapgcluster/monitoring-pmm3 --type=merge -p '{
11-
"spec":{
12-
"pmm":{"querySource":"pgstatstatements"},
13-
"extensions": {"builtin": {"pg_stat_statements": true }}}
14-
}
15-
'
16-
17-
# Wait for the pg_stat_statements extension to be created
18-
sleep 80
19-
2010
primary=$(get_pod_by_role monitoring-pmm3 primary name)
2111
kubectl -n ${NAMESPACE} exec ${primary} -- bash -c 'psql -c "SELECT * FROM pg_extension;"'
2212
if ! kubectl -n ${NAMESPACE} exec ${primary} -- bash -c 'psql -c "SELECT extname FROM pg_extension;"' | grep pg_stat_statements; then
Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
apiVersion: kuttl.dev/v1beta1
2+
kind: TestStep
3+
commands:
4+
- script: |-
5+
set -o errexit
6+
set -o xtrace
7+
8+
source ../../functions
9+
10+
kubectl -n ${NAMESPACE} patch perconapgcluster/monitoring-pmm3 --type=merge -p '{
11+
"spec":{
12+
"pmm":{"querySource":"pgstatmonitor"}
13+
}
14+
}'
15+
16+
# Wait for the pg_stat_monitor extension to be created and PMM to switch query source.
17+
sleep 80
18+
19+
primary=$(get_pod_by_role monitoring-pmm3 primary name)
20+
kubectl -n ${NAMESPACE} exec ${primary} -- bash -c 'psql -c "SELECT * FROM pg_extension;"'
21+
if ! kubectl -n ${NAMESPACE} exec ${primary} -- bash -c 'psql -c "SELECT extname FROM pg_extension;"' | grep pg_stat_monitor; then
22+
echo "pg_stat_monitor is not found in pg_extension"
23+
exit 1
24+
fi
25+
26+
# Verify that the QAN agent is running with pgstatmonitor query source.
27+
if ! kubectl -n ${NAMESPACE} exec ${primary} -c pmm-client -- pmm-admin list | grep postgresql_pgstatmonitor_agent; then
28+
echo "postgresql_pgstatmonitor_agent is not running"
29+
exit 1
30+
fi
31+
timeout: 360

e2e-tests/tests/monitoring-pmm3/07-check-password-leak.yaml renamed to e2e-tests/tests/monitoring-pmm3/08-check-password-leak.yaml

File renamed without changes.

e2e-tests/tests/monitoring/06-check-pgstatstatements-query-source.yaml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,6 @@ commands:
77
88
source ../../functions
99
10-
kubectl -n ${NAMESPACE} patch perconapgcluster/monitoring --type=merge -p '{
11-
"spec":{
12-
"pmm":{"querySource":"pgstatstatements"},
13-
"extensions": {"builtin": {"pg_stat_statements": true }}}
14-
}
15-
'
16-
17-
# Wait for the pg_stat_statements extension to be created
18-
sleep 80
19-
2010
primary=$(get_pod_by_role monitoring primary name)
2111
kubectl -n ${NAMESPACE} exec ${primary} -- bash -c 'psql -c "SELECT * FROM pg_extension;"'
2212
if ! kubectl -n ${NAMESPACE} exec ${primary} -- bash -c 'psql -c "SELECT extname FROM pg_extension;"' | grep pg_stat_statements; then
Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
apiVersion: kuttl.dev/v1beta1
2+
kind: TestStep
3+
commands:
4+
- script: |-
5+
set -o errexit
6+
set -o xtrace
7+
8+
source ../../functions
9+
10+
kubectl -n ${NAMESPACE} patch perconapgcluster/monitoring --type=merge -p '{
11+
"spec":{
12+
"pmm":{"querySource":"pgstatmonitor"}
13+
}
14+
}'
15+
16+
# Wait for the pg_stat_monitor extension to be created and PMM to switch query source.
17+
sleep 80
18+
19+
primary=$(get_pod_by_role monitoring primary name)
20+
kubectl -n ${NAMESPACE} exec ${primary} -- bash -c 'psql -c "SELECT * FROM pg_extension;"'
21+
if ! kubectl -n ${NAMESPACE} exec ${primary} -- bash -c 'psql -c "SELECT extname FROM pg_extension;"' | grep pg_stat_monitor; then
22+
echo "pg_stat_monitor is not found in pg_extension"
23+
exit 1
24+
fi
25+
26+
# Verify that the QAN agent is running with pgstatmonitor query source.
27+
if ! kubectl -n ${NAMESPACE} exec ${primary} -c pmm-client -- pmm-admin list | grep postgresql_pgstatmonitor_agent; then
28+
echo "postgresql_pgstatmonitor_agent is not running"
29+
exit 1
30+
fi
31+
timeout: 360

0 commit comments

Comments
 (0)