K8SPG-771 | Use CEL for validating that volumeSnapshots.className required (#1532)

* use CEL for validating .volumeSnapshots.className

Signed-off-by: Mayank Shah <mayank.shah@percona.com>

* change jenkins node to aws

---------

Signed-off-by: Mayank Shah <mayank.shah@percona.com>
Co-authored-by: Julio Pasinatto <julio.pasinatto@percona.com>

Author: mayankshah1607

Jenkinsfile

@@ -415,7 +415,7 @@ pipeline {
         AUTHOR_NAME = sh(script: "echo ${CHANGE_AUTHOR_EMAIL} | awk -F'@' '{print \$1}'", , returnStdout: true).trim()
     }
     agent {
-        label 'docker-x64-min'
+        label 'docker'
     }
     options {
         disableConcurrentBuilds(abortPrevious: true)
@@ -535,7 +535,7 @@ pipeline {
             parallel {
                 stage('cluster1') {
                     agent {
-                        label 'docker-x64-min'
+                        label 'docker'
                     }
                     steps {
                         prepareNode()
@@ -545,7 +545,7 @@ pipeline {
                 }
                 stage('cluster2') {
                     agent {
-                        label 'docker-x64-min'
+                        label 'docker'
                     }
                     steps {
                         prepareNode()
@@ -555,7 +555,7 @@ pipeline {
                 }
                 stage('cluster3') {
                     agent {
-                        label 'docker-x64-min'
+                        label 'docker'
                     }
                     steps {
                         prepareNode()
@@ -565,7 +565,7 @@ pipeline {
                 }
                 stage('cluster4') {
                     agent {
-                        label 'docker-x64-min'
+                        label 'docker'
                     }
                     steps {
                         prepareNode()

build/crd/percona/generated/pgv2.percona.com_perconapgclusters.yaml

@@ -9775,9 +9775,10 @@ spec:
                           https://k8s.io/docs/concepts/workloads/controllers/cron-jobs/#cron-schedule-syntax
                         minLength: 6
                         type: string
-                    required:
-                    - className
                     type: object
+                    x-kubernetes-validations:
+                    - message: className is required
+                      rule: has(self.className) && self.className != ""
                 type: object
                 x-kubernetes-validations:
                 - message: At least one repository must be configured when backups

config/crd/bases/pgv2.percona.com_perconapgclusters.yaml

@@ -10470,9 +10470,10 @@ spec:
                           https://k8s.io/docs/concepts/workloads/controllers/cron-jobs/#cron-schedule-syntax
                         minLength: 6
                         type: string
-                    required:
-                    - className
                     type: object
+                    x-kubernetes-validations:
+                    - message: className is required
+                      rule: has(self.className) && self.className != ""
                 type: object
                 x-kubernetes-validations:
                 - message: At least one repository must be configured when backups

deploy/bundle.yaml

@@ -10767,9 +10767,10 @@ spec:
                           https://k8s.io/docs/concepts/workloads/controllers/cron-jobs/#cron-schedule-syntax
                         minLength: 6
                         type: string
-                    required:
-                    - className
                     type: object
+                    x-kubernetes-validations:
+                    - message: className is required
+                      rule: has(self.className) && self.className != ""
                 type: object
                 x-kubernetes-validations:
                 - message: At least one repository must be configured when backups

deploy/crd.yaml

@@ -10767,9 +10767,10 @@ spec:
                           https://k8s.io/docs/concepts/workloads/controllers/cron-jobs/#cron-schedule-syntax
                         minLength: 6
                         type: string
-                    required:
-                    - className
                     type: object
+                    x-kubernetes-validations:
+                    - message: className is required
+                      rule: has(self.className) && self.className != ""
                 type: object
                 x-kubernetes-validations:
                 - message: At least one repository must be configured when backups

deploy/cw-bundle.yaml

@@ -10767,9 +10767,10 @@ spec:
                           https://k8s.io/docs/concepts/workloads/controllers/cron-jobs/#cron-schedule-syntax
                         minLength: 6
                         type: string
-                    required:
-                    - className
                     type: object
+                    x-kubernetes-validations:
+                    - message: className is required
+                      rule: has(self.className) && self.className != ""
                 type: object
                 x-kubernetes-validations:
                 - message: At least one repository must be configured when backups

pkg/apis/pgv2.percona.com/v2/perconapgcluster_types.go

@@ -638,6 +638,7 @@ const (
 	VolumeSnapshotModeOffline VolumeSnapshotMode = "offline"
 )
 
+// +kubebuilder:validation:XValidation:rule="has(self.className) && self.className != \"\"",message="className is required"
 type VolumeSnapshots struct {
 	// Mode of the VolumeSnapshot.
 	// +kubebuilder:validation:Enum={offline}
@@ -646,8 +647,7 @@ type VolumeSnapshots struct {
 	Mode VolumeSnapshotMode `json:"mode,omitempty"`
 
 	// Name of the VolumeSnapshotClass to use.
-	// +kubebuilder:validation:Required
-	ClassName string `json:"className"`
+	ClassName string `json:"className,omitempty"`
 
 	// Defines the Cron schedule for a VolumeSnapshot.
 	// Follows the standard Cron schedule syntax: