Conversation
|
|
gkech
force-pushed
the
K8SPG-741
branch
5 times, most recently
from
0aa9c09 to
473e93d
Compare
egegunes
reviewed
Apr 3, 2025
| if err != nil { | ||
| return result, err | ||
| } | ||
| clusterbyte, _ := json.Marshal(clusterRequestPayload) |
Contributor
There was a problem hiding this comment.
interesting, i wonder why upstream decided to ignore the error
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| . "github.com/onsi/gomega/gstruct" | ||
| "github.com/pkg/errors" | ||
| "github.com/pkg/errors" //nolint:depguard // This legacy test covers so much code, it logs the origin of unexpected errors. | ||
|
|
Contributor
There was a problem hiding this comment.
[goimports-reviser] reported by reviewdog 🐶
Suggested change
gkech
force-pushed
the
K8SPG-741
branch
3 times, most recently
from
4ec68cc to
bfe72f4
Compare
Issue: PGO-614
This test duplicates what's in the main e2e folder.
This version of controller-gen ignores "validation:Required" markers when the struct tag has "json:omitempty". Issue: PGO-1748
Issue: PGO-738 Issue: PGO-1829
For some reason, this was originally created without PGO listed as the manager for the configmap used by upgrade check.
These are specific to Postgres. Add tests and remove unused functions.
This is part of the "bugs" preset of golangci-lint. The "check-error-free-encoding" setting is recommended upstream.
These are ignored by golangci-lint by default.
Subtle bugs can arise when mixing the two. A type is more coherent when it behaves as only one of (1) a value or (2) a reference. A new linter identifies this situation but does not yet account for unmarshal methods on value types. See: https://go.dev/wiki/CodeReviewComments#receiver-type See: https://go.dev/wiki/MethodSets
The default unstructured converter does not complain if you try to convert a list to an object or vice versa. It also expects to be called with an empty target object.
The --jobs flag allows for some aspects of pg_upgrade to operate in
parallel. The documentation says:
This option can dramatically reduce the time to upgrade
a multi-database server running on a multiprocessor machine.
Issue: PGO-1958
See: https://www.postgresql.org/docs/current/pgupgrade.html
egegunes
previously approved these changes
Apr 10, 2025
Contributor
Author
|
passed locally
|
egegunes
approved these changes
Apr 14, 2025
pooknull
approved these changes
Apr 14, 2025
nmarukovich
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/CrunchyData/postgres-operator/compare/bdcb7eb9b50bd01f1674fc2f6ffdd022bd9058d5..072a19d31465d99963b52205885cd8e01c747f3a
We skipped these:
func getPGPVCName(lchanges and it is not issusing any more an error that we need cause we comment out the actually used error already)CHANGE DESCRIPTION
Problem:
Short explanation of the problem.
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability