K8SPG-1007: Rename upstream CRDs by egegunes · Pull Request #1561 · percona/percona-postgresql-operator

egegunes · 2026-04-21T06:53:14Z

CHANGE DESCRIPTION

Problem:
Re-using upstream CRDs makes it hard to deploy operator in a cluster where upstream operator is already running. This makes it hard to deploy our operator and ensure existing upstream clusters are not affected.

Solution:

Rename upstream CRD API group to upstream.pgv2.percona.com

The operator previously owned PostgresCluster under the group postgres-operator.crunchydata.com/v1beta1, and has been renamed to upstream.pgv2.percona.com/v1beta1. Existing running clusters have child objects (StatefulSets, Secrets, PVCs, etc.) whose ownerReferences still point at the old-group parent. PostgresCluster (upstream) controller re-parents those children to the new-group parent and then removes the old parent — without triggering restarts or deletes of the children.

PerconaPGCluster controller iterates through children of PostgresCluster and checks if owner references are updated. This is done only to inform user about the migration state and provide a better experience.

While the migration is in progress, there will be a status condition in PerconaPGCluster object:

    - lastTransitionTime: "2026-04-30T14:09:56Z"
      message: Waiting for owner references to be updated
      observedGeneration: 2
      reason: APIGroupMigrationInProgress
      status: "False"
      type: APIGroupMigration

After migration is completed, condition status will be True and check won't run again:

    - lastTransitionTime: "2026-04-30T14:18:12Z"
      message: All owner references are updated
      observedGeneration: 2
      reason: APIGroupMigrationCompleted
      status: "True"
      type: APIGroupMigration

Operator logs all children objects it checks on Info level. Logger name is APIGroupMigration, you can grep this string to see all operations.

Known limitations

Due to K8SPG-1015, cert-manager Issuer objects are not checked and not considered for setting condition to True.

Test cases

Installing renamed CRDs shouldn't affect clusters managed by the upstream operator.
Running the operator with the same namespace with upstream cluster shouldn't modify anything in the upstream cluster.
Running operator on a fresh cluster without legacy CRDs shouldn't start the migration check.
The list of children that operator checks need to be reviewed to ensure we are not missing anything.

CHECKLIST

Jira

Is the Jira ticket created and referenced properly?
Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

Is an E2E test/test case added for the new feature/change?
Are unit tests added where appropriate?

Config/Logging/Testability

Are all needed new/changed options added to default YAML files?
Are all needed new/changed options added to the Helm Chart?
Did we add proper logging messages for operator actions?
Did we ensure compatibility with the previous version or cluster upgrade process?
Does the change support oldest and newest supported PG version?
Does the change support oldest and newest supported Kubernetes version?

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

github-actions · 2026-04-21T06:53:45Z

  python3 -m yq -r \
    .spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.customTLSSecret.properties.name.description \
-    "${clusters_dir}/generated/postgres-operator.crunchydata.com_postgresclusters.yaml"
+    "${clusters_dir}/generated/upstream.pgv2.percona.com_postgresclusters.yaml"


[shfmt] _{reported by reviewdog 🐶}

Suggested change

python3 -m yq -r \

.spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.customTLSSecret.properties.name.description \

"${clusters_dir}/generated/postgres-operator.crunchydata.com_postgresclusters.yaml"

"${clusters_dir}/generated/upstream.pgv2.percona.com_postgresclusters.yaml"

python3 -m yq -r \

.spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.customTLSSecret.properties.name.description \

"${clusters_dir}/generated/upstream.pgv2.percona.com_postgresclusters.yaml"

github-actions · 2026-04-21T06:53:46Z

-    "${clusters_dir}/generated/postgres-operator.crunchydata.com_postgresclusters.yaml"
+    "${clusters_dir}/generated/upstream.pgv2.percona.com_postgresclusters.yaml"
 )
 name_desc_without_todo=$(sed 's/ TODO.*//g' <<< "${name_desc_with_todo}")


[shfmt] _{reported by reviewdog 🐶}

Suggested change

name_desc_without_todo=$(sed 's/ TODO.*//g' <<< "${name_desc_with_todo}")

name_desc_without_todo=$(sed 's/ TODO.*//g' <<<"${name_desc_with_todo}")

github-actions · 2026-04-21T06:53:46Z

 	[{ op: "remove", path: "/work" }]
 ' \
-	"${clusters_dir}/generated/postgres-operator.crunchydata.com_postgresclusters.yaml" > "${clusters_dir}/todos.yaml"
+	"${clusters_dir}/generated/upstream.pgv2.percona.com_postgresclusters.yaml" > "${clusters_dir}/todos.yaml"


[shfmt] _{reported by reviewdog 🐶}

Suggested change

"${clusters_dir}/generated/upstream.pgv2.percona.com_postgresclusters.yaml" > "${clusters_dir}/todos.yaml"

"${clusters_dir}/generated/upstream.pgv2.percona.com_postgresclusters.yaml" >"${clusters_dir}/todos.yaml"

github-actions · 2026-04-21T06:53:46Z

 	[{ op: "remove", path: "/work" }]
 ' \
-	"${upgrades_dir}/generated/postgres-operator.crunchydata.com_pgupgrades.yaml" > "${upgrades_dir}/todos.yaml"
+	"${upgrades_dir}/generated/upstream.pgv2.percona.com_pgupgrades.yaml" > "${upgrades_dir}/todos.yaml"


[shfmt] _{reported by reviewdog 🐶}

Suggested change

"${upgrades_dir}/generated/upstream.pgv2.percona.com_pgupgrades.yaml" > "${upgrades_dir}/todos.yaml"

"${upgrades_dir}/generated/upstream.pgv2.percona.com_pgupgrades.yaml" >"${upgrades_dir}/todos.yaml"

github-actions · 2026-04-21T06:53:47Z

@@ -17,7 +17,7 @@ import (



[goimports-reviser] _{reported by reviewdog 🐶}

Suggested change

"sigs.k8s.io/controller-runtime/pkg/client"

github-actions · 2026-04-21T06:53:47Z

@@ -18,7 +18,7 @@ import (



[goimports-reviser] _{reported by reviewdog 🐶}

Suggested change

corev1 "k8s.io/api/core/v1"

github-actions · 2026-04-21T06:53:47Z

 	"github.com/pkg/errors"



[goimports-reviser] _{reported by reviewdog 🐶}

Suggested change

"github.com/pkg/errors"

github-actions · 2026-04-21T06:53:49Z

[goimports-reviser] _{reported by reviewdog 🐶}

percona-postgresql-operator/internal/controller/standalone_pgadmin/service.go

Lines 16 to 19 in 5e81eac

apierrors "k8s.io/apimachinery/pkg/api/errors"

"github.com/pkg/errors"

github-actions · 2026-04-21T06:53:49Z

[goimports-reviser] _{reported by reviewdog 🐶}

percona-postgresql-operator/internal/controller/standalone_pgadmin/statefulset.go

Lines 16 to 17 in 5e81eac

"github.com/pkg/errors"

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

mayankshah1607 · 2026-04-23T08:15:07Z

@@ -0,0 +1,36 @@
+apiVersion: kustomize.config.k8s.io/v1beta1


Typo in file name

thanks, fixed

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

gkech · 2026-04-27T10:20:00Z

+		return reconcile.Result{}, errors.Wrap(err, "get new PostgresCluster")
+	}
+
+	if legacy.GetDeletionTimestamp().IsZero() {


Wondering if this logic can have issues in case something like argocd/etc deletes legacy objects, marking them with deletion timestamp and for edge cases not triggering the logic here. Maybe we can add the finalizers early?

hmm not sure if i follow, adding the finalizer is literally the first thing we do

gkech · 2026-04-27T11:08:31Z

We also have a lot of linting suggestions from golangci-lint, we should resolve these as well.

gkech · 2026-04-27T11:29:30Z

+		return nil
+	}
+	patch := client.MergeFrom(legacy.DeepCopy())
+	legacy.SetFinalizers(nil)


Why are we removing all the finalizers and not only the one we added with this logic?

#1561 (comment)

egegunes · 2026-04-27T14:12:35Z

We also have a lot of linting suggestions from golangci-lint, we should resolve these as well.

@gkech they are all existing issues surfaced because I touched every single file from upstream. I don't want to fix them :/

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

github-actions · 2026-04-30T15:32:49Z

+import (
+	"context"
+
+	apierrors "k8s.io/apimachinery/pkg/api/errors"


[goimports-reviser] _{reported by reviewdog 🐶}

Suggested change

apierrors "k8s.io/apimachinery/pkg/api/errors"

"github.com/pkg/errors"

apierrors "k8s.io/apimachinery/pkg/api/errors"

github-actions · 2026-04-30T15:32:50Z

+	"github.com/percona/percona-postgresql-operator/v2/internal/naming"
+	v2 "github.com/percona/percona-postgresql-operator/v2/pkg/apis/pgv2.percona.com/v2"
+	"github.com/percona/percona-postgresql-operator/v2/pkg/apis/upstream.pgv2.percona.com/v1beta1"
+	"github.com/pkg/errors"


[goimports-reviser] _{reported by reviewdog 🐶}

Suggested change

"github.com/pkg/errors"

mayankshah1607 · 2026-05-01T03:59:57Z

+		ObservedGeneration: cr.GetGeneration(),
+	})
+	if err != nil {
+		return errors.Wrap(err, "set status condition to false")


Suggested change

return errors.Wrap(err, "set status condition to false")

return errors.Wrap(err, "set status condition to true")

mayankshah1607 · 2026-05-01T04:08:47Z

+	legacy.SetGroupVersionKind(LegacyGVK)
+
+	if err := r.Client.Get(ctx, types.NamespacedName{Name: cr.Name, Namespace: cr.Namespace}, legacy); err != nil {
+		return client.IgnoreNotFound(err)


How would this condition work for new clusters when legacy CRD is installed? IIUC, any new PerconaPGCluster will not be created with legacy PostgresCluster object. So according to this logic, it will do an early return here and the new PerconaPGCluster will be stuck with condition APIGroupMigration == False

It won't affect anything, but there will be a misleading condition

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

JNKPercona · 2026-05-04T10:33:27Z

Test Name	Result	Time
backup-enable-disable	passed	00:13:42
builtin-extensions	passed	00:05:55
cert-manager-tls	passed	00:07:32
custom-envs	passed	00:18:22
custom-extensions	passed	00:14:07
custom-tls	passed	00:07:12
database-init-sql	passed	00:02:19
demand-backup	passed	00:22:07
demand-backup-offline-snapshot	passed	00:12:34
dynamic-configuration	passed	00:03:26
finalizers	passed	00:03:32
init-deploy	passed	00:02:38
huge-pages	passed	00:02:58
major-upgrade-13-to-14	passed	00:10:52
major-upgrade-14-to-15	passed	00:11:05
major-upgrade-15-to-16	passed	00:11:59
major-upgrade-16-to-17	passed	00:15:26
major-upgrade-17-to-18	passed	00:10:31
ldap	passed	00:03:35
ldap-tls	passed	00:08:37
monitoring	failure	00:06:38
monitoring-pmm3	passed	00:09:26
one-pod	passed	00:06:17
operator-self-healing	passed	00:10:37
pitr	passed	00:12:06
scaling	passed	00:04:49
scheduled-backup	passed	00:26:26
self-healing	passed	00:08:09
sidecars	passed	00:02:29
standby-pgbackrest	passed	00:18:11
standby-streaming	passed	00:12:50
start-from-backup	passed	00:11:35
tablespaces	passed	00:06:44
telemetry-transfer	passed	00:04:24
upgrade-consistency	passed	00:06:08
upgrade-minor	failure	00:16:38
users	passed	00:04:27

Summary	Value
Tests Run	37/37
Job Duration	02:23:52
Total Test Time	05:56:41

commit: f0daa58
image: perconalab/percona-postgresql-operator:PR-1561-f0daa5879

egegunes added 8 commits April 20, 2026 16:58

rename upstream api package

8d39567

fix old api references

bb21125

rename CRDs

3ade8de

fix api version

c4baaf7

remove testing dir

ac6f625

fix rbacs

3955649

add migration controller

5cee9a4

update manifests

5e81eac

Copilot AI review requested due to automatic review settings April 21, 2026 06:53

Copilot AI reviewed Apr 21, 2026

View reviewed changes

github-actions Bot reviewed Apr 21, 2026

View reviewed changes

egegunes changed the title ~~Rename upstream CRDs~~ K8SPG-1007: Rename upstream CRDs Apr 21, 2026

egegunes and others added 3 commits April 22, 2026 15:23

fix unit tests

92f6a31

fix upgrade-minor

8f121cc

Merge branch 'main' into crd-rename

bb84b04

Copilot AI review requested due to automatic review settings April 23, 2026 08:14

Copilot AI reviewed Apr 23, 2026

View reviewed changes

mayankshah1607 reviewed Apr 23, 2026

View reviewed changes

hors and others added 2 commits April 23, 2026 15:36

Merge branch 'main' into crd-rename

50cd1dd

fix typo

b1b4cfd

Copilot AI review requested due to automatic review settings April 24, 2026 09:12

Copilot AI reviewed Apr 24, 2026

View reviewed changes

egegunes marked this pull request as ready for review April 24, 2026 09:26

egegunes requested review from eleo007, jvpasinatto, pooknull and valmiranogueira as code owners April 24, 2026 09:26

gkech reviewed Apr 27, 2026

View reviewed changes

egegunes added 4 commits April 27, 2026 16:06

address mayank's comments

855095d

remove references to testing/

87e562b

use require to assert owner reference

0aefa6e

fix issues due to review comments

5986a05

egegunes added 2 commits April 28, 2026 13:39

address review comments

66a29e0

Merge branch 'main' into crd-rename

497af8d

Copilot AI review requested due to automatic review settings April 28, 2026 11:37

Copilot AI reviewed Apr 28, 2026

View reviewed changes

hors added 2 commits April 29, 2026 00:15

fix timeouts

ad66ef7

fix tests

fb73327

Copilot AI review requested due to automatic review settings April 29, 2026 10:32

Copilot AI reviewed Apr 29, 2026

View reviewed changes

egegunes added 3 commits April 30, 2026 14:23

remove migration controller

f1ede33

fix updating owner references of issuer & certificates

f15c14a

add status condition for migration status

b71131c

Copilot AI review requested due to automatic review settings April 30, 2026 15:32

Copilot AI reviewed Apr 30, 2026

View reviewed changes

github-actions Bot reviewed Apr 30, 2026

View reviewed changes

mayankshah1607 reviewed May 1, 2026

View reviewed changes

address review comments

e077de3

egegunes requested a review from mayankshah1607 May 4, 2026 06:49

Merge branch 'main' into crd-rename

5c8d2a9

Copilot AI review requested due to automatic review settings May 4, 2026 07:14

Copilot AI reviewed May 4, 2026

View reviewed changes

fix owner references for ca cert

f0daa58

	name_desc_without_todo=$(sed 's/ TODO.*//g' <<< "${name_desc_with_todo}")
	name_desc_without_todo=$(sed 's/ TODO.*//g' <<<"${name_desc_with_todo}")

	"${clusters_dir}/generated/upstream.pgv2.percona.com_postgresclusters.yaml" > "${clusters_dir}/todos.yaml"
	"${clusters_dir}/generated/upstream.pgv2.percona.com_postgresclusters.yaml" >"${clusters_dir}/todos.yaml"

	"${upgrades_dir}/generated/upstream.pgv2.percona.com_pgupgrades.yaml" > "${upgrades_dir}/todos.yaml"
	"${upgrades_dir}/generated/upstream.pgv2.percona.com_pgupgrades.yaml" >"${upgrades_dir}/todos.yaml"

	apierrors "k8s.io/apimachinery/pkg/api/errors"

	"github.com/pkg/errors"

	return errors.Wrap(err, "set status condition to false")
	return errors.Wrap(err, "set status condition to true")

Conversation

egegunes commented Apr 21, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CHANGE DESCRIPTION

Known limitations

Test cases

CHECKLIST

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gkech commented Apr 27, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

egegunes commented Apr 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

egegunes commented Apr 21, 2026 •

edited by atlassian Bot

Loading