K8SPG-1017 leaf cert function needs to check whether the existing secret is already managed by internal PKI before switching to cert-manager#1578
Open
K8SPG-1017 leaf cert function needs to check whether the existing secret is already managed by internal PKI before switching to cert-manager#1578
Conversation
…ret is already managed by internal PKI before switching to cert-manager
gkech
requested review from
egegunes,
hors,
mayankshah1607,
nmarukovich,
oksana-grishchenko and
pooknull
as code owners
egegunes
reviewed
May 5, 2026
| err = r.Client.Get(ctx, client.ObjectKeyFromObject(rootSecret), rootSecret) | ||
| if err != nil { | ||
| if k8serrors.IsNotFound(err) { | ||
| return true, nil |
Contributor
There was a problem hiding this comment.
should we really return true here?
Contributor
Author
There was a problem hiding this comment.
There's no pre-existing internally-managed secret to conflict with. Since cert-manager is available and no secret has been created yet, it's safe to let cert-manager create and manage the root CA from scratch. That's the idea.
hors
reviewed
May 5, 2026
Collaborator
hors
left a comment
hors
left a comment
There was a problem hiding this comment.
Do we have a plan to add e2e test?
Contributor
Author
We are about to add an improvement. The issue was that we needed to refactor the flow on the existing test because initially the cluster should start without cert-manager installed, then make assertions, then install cert-manager and ensure that nothing happens. And then destroy it and recreate it while cert-manager is installed. |
…i certs and cert manager is installed afterwards
gkech
requested review from
eleo007,
jvpasinatto and
valmiranogueira
as code owners
Contributor
Author
|
nmarukovich
approved these changes
May 5, 2026
Collaborator
commit: 29e346e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
Each leaf cert function needs to check whether the existing secret is already managed by internal PKI before switching to cert-manager. If the root CA secret lacks the cert-manager.io/certificate-name annotation, all leaf certs should stay on internal PKI regardless of whether cert-manager is installed.
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability