test: re-enable upgrade check scheduler test#1586
Open
immanuwell wants to merge 1 commit into
Open
Conversation
immanuwell
requested review from
egegunes,
gkech,
hors,
mayankshah1607,
nmarukovich,
oksana-grishchenko and
pooknull
as code owners
|
|
Contributor
|
@immanuwell I'm not sure if we want to run those tests at all... They are checking upstream's upgrade registration logic which we don't use. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removed a stale skip from the upgrade check scheduler test.
This test used to say it broke under
go test ./..., but that does not repro anymore. So yeah, lets get this tiny bit of coverage back in the mix.Repro
On current main:
go test ./internal/upgradecheck -run TestCheckForUpgradesScheduler -count=1 -vThe test is reported as skipped, so the scheduler panic recovery and ticker path are not actually checked. Kinda leaving money on the table.
With this branch, the same test runs for real.
Checked
I searched GitHub issues/PRs for
upgradecheck,checkForUpgrades, scheduler, and the oldgo test ./...note. Did not find a direct issue to link.