address review comments: use the same test with additional SC assertions

Author: shajia-deshaw

pkg/controller/perconaservermongodbrestore/physical_test.go

@@ -19,6 +19,13 @@ import (
 func TestUpdateStatefulSetForPhysicalRestore(t *testing.T) {
 	ctx := context.Background()
 
+	nonRoot := true
+	allowPrivEsc := false
+	initSC := &corev1.SecurityContext{
+		RunAsNonRoot:             &nonRoot,
+		AllowPrivilegeEscalation: &allowPrivEsc,
+	}
+
 	cluster := &psmdbv1.PerconaServerMongoDB{
 		ObjectMeta: metav1.ObjectMeta{
 			Name:      "my-cluster",
@@ -40,6 +47,7 @@ func TestUpdateStatefulSetForPhysicalRestore(t *testing.T) {
 				Users: "users-secret",
 				SSL:   "ssl-secret",
 			},
+			InitContainerSecurityContext: initSC,
 		},
 	}
 
@@ -103,10 +111,15 @@ func TestUpdateStatefulSetForPhysicalRestore(t *testing.T) {
 		assert.NotEqual(t, naming.ContainerBackupAgent, c.Name)
 	}
 
-	assert.True(t,
-		slices.ContainsFunc(updatedSTS.Spec.Template.Spec.InitContainers, func(c corev1.Container) bool {
-			return c.Name == "pbm-init"
-		}))
+	var pbmInit *corev1.Container
+	for i := range updatedSTS.Spec.Template.Spec.InitContainers {
+		if updatedSTS.Spec.Template.Spec.InitContainers[i].Name == "pbm-init" {
+			pbmInit = &updatedSTS.Spec.Template.Spec.InitContainers[i]
+			break
+		}
+	}
+	assert.NotNil(t, pbmInit)
+	assert.Equal(t, cluster.Spec.InitContainerSecurityContext, pbmInit.SecurityContext)
 
 	assert.Equal(t, "/opt/percona/physical-restore-ps-entry.sh", updatedSTS.Spec.Template.Spec.Containers[0].Command[0])
 
@@ -121,95 +134,3 @@ func TestUpdateStatefulSetForPhysicalRestore(t *testing.T) {
 	assert.Equal(t, "PBM_MONGODB_URI", lastEnvVar.Name)
 	assert.Equal(t, expectedURI, lastEnvVar.Value)
 }
-
-func TestUpdateStatefulSetForPhysicalRestoreSecurityContext(t *testing.T) {
-	ctx := context.Background()
-
-	nonRoot := true
-	allowPrivEsc := false
-	cluster := &psmdbv1.PerconaServerMongoDB{
-		ObjectMeta: metav1.ObjectMeta{
-			Name:      "my-cluster",
-			Namespace: "default",
-		},
-		Spec: psmdbv1.PerconaServerMongoDBSpec{
-			CRVersion: version.Version(),
-			Backup: psmdbv1.BackupSpec{
-				Image: "percona/percona-backup-mongodb:latest",
-			},
-			ImagePullPolicy: corev1.PullIfNotPresent,
-			Secrets: &psmdbv1.SecretsSpec{
-				Users: "users-secret",
-				SSL:   "ssl-secret",
-			},
-			InitContainerSecurityContext: &corev1.SecurityContext{
-				RunAsNonRoot:             &nonRoot,
-				AllowPrivilegeEscalation: &allowPrivEsc,
-			},
-		},
-	}
-
-	sts := &appsv1.StatefulSet{
-		ObjectMeta: metav1.ObjectMeta{
-			Name:      "my-cluster-rs0",
-			Namespace: "default",
-		},
-		Spec: appsv1.StatefulSetSpec{
-			Selector: &metav1.LabelSelector{
-				MatchLabels: map[string]string{"app": "my-cluster"},
-			},
-			Template: corev1.PodTemplateSpec{
-				ObjectMeta: metav1.ObjectMeta{
-					Labels: map[string]string{"app": "my-cluster"},
-				},
-				Spec: corev1.PodSpec{
-					Containers: []corev1.Container{
-						{
-							Name:  "mongod",
-							Image: "percona/percona-server-mongodb:latest",
-						},
-						{
-							Name:  naming.ContainerBackupAgent,
-							Image: "percona/percona-backup-agent:latest",
-						},
-					},
-				},
-			},
-		},
-	}
-
-	secretTLS := &corev1.Secret{
-		ObjectMeta: metav1.ObjectMeta{
-			Name:      cluster.Spec.Secrets.SSL,
-			Namespace: cluster.Namespace,
-		},
-		Data: map[string][]byte{
-			"ca.crt":  {},
-			"tls.crt": {},
-			"tls.key": {},
-		},
-	}
-
-	r := fakeReconciler(cluster, sts, secretTLS)
-	namespacedName := types.NamespacedName{
-		Name:      sts.Name,
-		Namespace: sts.Namespace,
-	}
-
-	err := r.updateStatefulSetForPhysicalRestore(ctx, cluster, namespacedName, 27017)
-	assert.NoError(t, err)
-
-	updatedSTS := &appsv1.StatefulSet{}
-	err = r.client.Get(ctx, namespacedName, updatedSTS)
-	assert.NoError(t, err)
-
-	var pbmInit *corev1.Container
-	for i := range updatedSTS.Spec.Template.Spec.InitContainers {
-		if updatedSTS.Spec.Template.Spec.InitContainers[i].Name == "pbm-init" {
-			pbmInit = &updatedSTS.Spec.Template.Spec.InitContainers[i]
-			break
-		}
-	}
-	assert.NotNil(t, pbmInit)
-	assert.Equal(t, cluster.Spec.InitContainerSecurityContext, pbmInit.SecurityContext)
-}