Add revisionHistoryLimit option to PerconaServerMongoDB CRD

lake-yoo · claude · lake-yoo · commit 3075f5d4ca15 · 2026-01-29T17:02:19.000+09:00
This allows users to control the number of ControllerRevision
objects retained for StatefulSets managed by the operator.

Co-Authored-By: Claude Opus 4.5 &lt;noreply@anthropic.com&gt;
diff --git a/config/crd/bases/psmdb.percona.com_perconaservermongodbs.yaml b/config/crd/bases/psmdb.percona.com_perconaservermongodbs.yaml
@@ -11759,6 +11759,9 @@ spec:
                   - size
                   type: object
                 type: array
+              revisionHistoryLimit:
+                format: int32
+                type: integer
               roles:
                 items:
                   properties:
diff --git a/deploy/bundle.yaml b/deploy/bundle.yaml
@@ -1,3 +1,4 @@
+# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
 apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
@@ -12646,6 +12647,9 @@ spec:
                   - size
                   type: object
                 type: array
+              revisionHistoryLimit:
+                format: int32
+                type: integer
               roles:
                 items:
                   properties:
diff --git a/deploy/cr.yaml b/deploy/cr.yaml
@@ -43,6 +43,7 @@ spec:
 #    terminationGracePeriod: false
 #    backupIfUnhealthy: false
   updateStrategy: SmartUpdate
+#  revisionHistoryLimit: 10
 #  ignoreAnnotations:
 #    - service.beta.kubernetes.io/aws-load-balancer-backend-protocol
 #  ignoreLabels:
diff --git a/deploy/crd.yaml b/deploy/crd.yaml
@@ -1,3 +1,4 @@
+# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
 apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
@@ -12646,6 +12647,9 @@ spec:
                   - size
                   type: object
                 type: array
+              revisionHistoryLimit:
+                format: int32
+                type: integer
               roles:
                 items:
                   properties:
diff --git a/deploy/cw-bundle.yaml b/deploy/cw-bundle.yaml
@@ -1,3 +1,4 @@
+# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
 apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
@@ -12646,6 +12647,9 @@ spec:
                   - size
                   type: object
                 type: array
+              revisionHistoryLimit:
+                format: int32
+                type: integer
               roles:
                 items:
                   properties:
diff --git a/e2e-tests/version-service/conf/crd.yaml b/e2e-tests/version-service/conf/crd.yaml
@@ -1,3 +1,4 @@
+# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
 apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
@@ -12646,6 +12647,9 @@ spec:
                   - size
                   type: object
                 type: array
+              revisionHistoryLimit:
+                format: int32
+                type: integer
               roles:
                 items:
                   properties:
diff --git a/pkg/apis/psmdb/v1/psmdb_types.go b/pkg/apis/psmdb/v1/psmdb_types.go
@@ -86,6 +86,7 @@ type PerconaServerMongoDBSpec struct {
 	ImagePullPolicy              corev1.PullPolicy                    `json:"imagePullPolicy,omitempty"`
 	PMM                          PMMSpec                              `json:"pmm,omitempty"`
 	UpdateStrategy               appsv1.StatefulSetUpdateStrategyType `json:"updateStrategy,omitempty"`
+	RevisionHistoryLimit         *int32                               `json:"revisionHistoryLimit,omitempty"`
 	UpgradeOptions               UpgradeOptions                       `json:"upgradeOptions,omitempty"`
 	SchedulerName                string                               `json:"schedulerName,omitempty"`
 	ClusterServiceDNSSuffix      string                               `json:"clusterServiceDNSSuffix,omitempty"`
diff --git a/pkg/apis/psmdb/v1/zz_generated.deepcopy.go b/pkg/apis/psmdb/v1/zz_generated.deepcopy.go
diff --git a/pkg/psmdb/mongos.go b/pkg/psmdb/mongos.go
@@ -51,8 +51,9 @@ func MongosStatefulsetSpec(cr *api.PerconaServerMongoDB, template corev1.PodTemp
 		Selector: &metav1.LabelSelector{
 			MatchLabels: naming.MongosLabels(cr),
 		},
-		Template:       template,
-		UpdateStrategy: updateStrategy,
+		Template:             template,
+		UpdateStrategy:       updateStrategy,
+		RevisionHistoryLimit: cr.Spec.RevisionHistoryLimit,
 	}
 }
 
diff --git a/pkg/psmdb/statefulset.go b/pkg/psmdb/statefulset.go
@@ -453,6 +453,7 @@ func StatefulSpec(ctx context.Context, cr *api.PerconaServerMongoDB, replset *ap
 			},
 		},
 		UpdateStrategy:       updateStrategy,
+		RevisionHistoryLimit: cr.Spec.RevisionHistoryLimit,
 		VolumeClaimTemplates: volumeClaimTemplates,
 	}, nil
 }

Original file line number	Diff line number	Diff line change
`@@ -51,8 +51,9 @@ func MongosStatefulsetSpec(cr *api.PerconaServerMongoDB, template corev1.PodTemp`
`51`	`51`	`Selector: &metav1.LabelSelector{`
`52`	`52`	`MatchLabels: naming.MongosLabels(cr),`
`53`	`53`	`},`
`54`		`- Template: template,`
`55`		`- UpdateStrategy: updateStrategy,`
	`54`	`+ Template: template,`
	`55`	`+ UpdateStrategy: updateStrategy,`
	`56`	`+ RevisionHistoryLimit: cr.Spec.RevisionHistoryLimit,`
`56`	`57`	`}`
`57`	`58`	`}`
`58`	`59`
Original file line number	Diff line number	Diff line change
`@@ -453,6 +453,7 @@ func StatefulSpec(ctx context.Context, cr api.PerconaServerMongoDB, replset ap`
`453`	`453`	`},`
`454`	`454`	`},`
`455`	`455`	`UpdateStrategy: updateStrategy,`
	`456`	`+ RevisionHistoryLimit: cr.Spec.RevisionHistoryLimit,`
`456`	`457`	`VolumeClaimTemplates: volumeClaimTemplates,`
`457`	`458`	`}, nil`
`458`	`459`	`}`