K8SPSMDB add support for Rancher#2412
Open
valmiranogueira wants to merge 7 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the E2E test harness to run reliably on Rancher/RKE2 (and other managed Kubernetes platforms) by centralizing test configuration, normalizing storage sizing, and refactoring runtime-class / monitoring / snapshot helpers to be platform-aware.
Changes:
- Centralized E2E environment variables and platform detection into
e2e-tests/varsand refactorede2e-tests/functionsto source it. - Normalized PVC resize/storage requests from
GtoGiacross resize/autoscaling tests to avoid provider-specific rounding issues (e.g., Longhorn). - Added Rancher-specific snapshot class support and hardened PMM/monitoring interactions by routing curl calls through a helper (to better handle special characters in credentials).
Reviewed changes
Copilot reviewed 81 out of 82 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| e2e-tests/vars | New centralized variables/platform-detection script used by E2E functions. |
| e2e-tests/functions | Refactor to source vars, add Rancher handling, runtime class helper, snapshot class helpers, and execute_curl. |
| e2e-tests/build | Avoids sourcing functions during image build; computes git/image variables locally. |
| e2e-tests/release_versions | Adds Rancher/RKE2 and cert-manager version entries used by the E2E release matrix. |
| e2e-tests/unsafe-psa/run | Uses Gi units for PVC resize validation. |
| e2e-tests/storage/run | Makes OpenShift detection check consistent ([[ -n \"$OPENSHIFT\" ]]). |
| e2e-tests/storage/conf/hostpath-helper.yml | Adjusts cleanup container command/securityContext for hostpath helper behavior. |
| e2e-tests/security-context/run | Makes OpenShift detection checks consistent/quoted. |
| e2e-tests/pvc-resize/run | Converts G→Gi and standardizes EKS/OpenShift conditionals. |
| e2e-tests/pvc-resize/conf/some-name.yml | Updates baseline PVC request 1G→1Gi. |
| e2e-tests/pvc-resize/compare/statefulset_some-name-rs0.yml | Updates expected PVC request 1G→1Gi. |
| e2e-tests/pvc-resize/compare/statefulset_some-name-rs0-oc.yml | Updates expected PVC request 1G→1Gi. |
| e2e-tests/pvc-auto-resize/run | Updates EKS/OpenShift checks and strengthens maxSize verification logic. |
| e2e-tests/pvc-auto-resize/conf/some-name.yml | Updates baseline PVC request 1G→1Gi. |
| e2e-tests/pvc-auto-resize/conf/some-name-eks.yml | Updates baseline PVC request 1G→1Gi. |
| e2e-tests/pvc-auto-resize/compare/statefulset_some-name-rs0.yml | Updates expected PVC request 1G→1Gi. |
| e2e-tests/pvc-auto-resize/compare/statefulset_some-name-rs0-oc.yml | Updates expected PVC request 1G→1Gi. |
| e2e-tests/pitr-sharded/run | Replaces inline RuntimeClass logic with create_runtime_class. |
| e2e-tests/pitr-sharded/compare/statefulset_some-name-rs0-oc.yml | Updates expected runtimeClassName and secret volume mounts for OC fixtures. |
| e2e-tests/pitr-sharded/compare/statefulset_some-name-rs1-oc.yml | Updates OC fixture to include users secret volume/mount. |
| e2e-tests/pitr-sharded/compare/statefulset_some-name-rs2-oc.yml | Updates OC fixture to include users secret volume/mount. |
| e2e-tests/pitr-sharded/compare/statefulset_some-name-cfg-oc.yml | Updates OC fixture to include runtimeClassName. |
| e2e-tests/pitr-sharded/compare/statefulset_some-name-rs0-4-oc.yml | Removes obsolete OC compare fixture. |
| e2e-tests/pitr-sharded/compare/statefulset_some-name-rs1-4-oc.yml | Removes obsolete OC compare fixture. |
| e2e-tests/pitr-sharded/compare/statefulset_some-name-rs2-4-oc.yml | Removes obsolete OC compare fixture. |
| e2e-tests/pitr-sharded/compare/statefulset_some-name-cfg-4-oc.yml | Removes obsolete OC compare fixture. |
| e2e-tests/pitr-physical/compare/statefulset_some-name-rs1-oc.yml | Updates OC fixture to include users secret volume/mount. |
| e2e-tests/pitr-physical/compare/statefulset_some-name-rs2-oc.yml | Updates OC fixture to include users secret volume/mount. |
| e2e-tests/pitr-physical/compare/statefulset_some-name-rs2-4-oc.yml | Removes obsolete OC compare fixture. |
| e2e-tests/pitr-physical/compare/statefulset_some-name-rs1-4-oc.yml | Removes obsolete OC compare fixture. |
| e2e-tests/pitr-physical/compare/statefulset_some-name-rs0-4-oc.yml | Removes obsolete OC compare fixture. |
| e2e-tests/pitr-physical/compare/statefulset_some-name-cfg-4-oc.yml | Removes obsolete OC compare fixture. |
| e2e-tests/pitr-physical-backup-source/compare/statefulset_some-name-rs1-oc.yml | Updates OC fixture to include users secret volume/mount. |
| e2e-tests/pitr-physical-backup-source/compare/statefulset_some-name-rs2-oc.yml | Updates OC fixture to include users secret volume/mount. |
| e2e-tests/pitr-physical-backup-source/compare/statefulset_some-name-rs2-4-oc.yml | Removes obsolete OC compare fixture. |
| e2e-tests/pitr-physical-backup-source/compare/statefulset_some-name-rs1-4-oc.yml | Removes obsolete OC compare fixture. |
| e2e-tests/pitr-physical-backup-source/compare/statefulset_some-name-rs0-4-oc.yml | Removes obsolete OC compare fixture. |
| e2e-tests/pitr-physical-backup-source/compare/statefulset_some-name-cfg-4-oc.yml | Removes obsolete OC compare fixture. |
| e2e-tests/multi-cluster-service/run | Uses safer numeric check for GKE flag and refactors RuntimeClass creation via helper. |
| e2e-tests/monitoring-pmm3/run | Uses execute_curl and adjusts PMM inventory/QAN calls to avoid URL-unsafe password issues. |
| e2e-tests/monitoring-2-0/run | Uses execute_curl for PMM API key and inventory requests; normalizes OpenShift checks. |
| e2e-tests/ldap/run | Normalizes OpenShift checks. |
| e2e-tests/ldap-tls/run | Normalizes OpenShift checks. |
| e2e-tests/init-deploy/run | Replaces inline RuntimeClass logic with create_runtime_class. |
| e2e-tests/init-deploy/compare/statefulset_another-name-rs0-oc.yml | Updates OC fixture for runtimeClassName and backup-agent container. |
| e2e-tests/init-deploy/compare/statefulset_another-name-rs0-4-oc.yml | Removes obsolete OC compare fixture. |
| e2e-tests/expose-sharded/run | Replaces inline RuntimeClass logic with create_runtime_class and removes explicit delete. |
| e2e-tests/expose-sharded/compare/statefulset_some-name-mongos-oc.yml | Updates OC fixture (securityContext placement + runtimeClassName). |
| e2e-tests/expose-sharded/compare/statefulset_some-name-cfg-oc.yml | Updates OC fixture to include runtimeClassName. |
| e2e-tests/expose-sharded/compare/statefulset_some-name-rs0-4-oc.yml | Removes obsolete OC compare fixture. |
| e2e-tests/expose-sharded/compare/statefulset_some-name-mongos-4-oc.yml | Removes obsolete OC compare fixture. |
| e2e-tests/expose-sharded/compare/statefulset_some-name-cfg-4-oc.yml | Removes obsolete OC compare fixture. |
| e2e-tests/demand-backup-snapshot/run | Defers snapshot class selection to helper and ensures class is deployed first. |
| e2e-tests/demand-backup-snapshot-vault/run | Same snapshot class flow changes as non-vault snapshot test. |
| e2e-tests/demand-backup-sharded/run | Replaces inline RuntimeClass logic with create_runtime_class. |
| e2e-tests/demand-backup-sharded/compare/statefulset_some-name-rs0-oc.yml | Updates OC fixture to include runtimeClassName. |
| e2e-tests/demand-backup-sharded/compare/statefulset_some-name-mongos-oc.yml | Updates OC fixture for runtimeClassName/securityContext expectations. |
| e2e-tests/demand-backup-sharded/compare/statefulset_some-name-cfg-oc.yml | Updates OC fixture to include runtimeClassName. |
| e2e-tests/demand-backup-sharded/compare/statefulset_some-name-rs0-4-oc.yml | Removes obsolete OC compare fixture. |
| e2e-tests/demand-backup-sharded/compare/statefulset_some-name-mongos-4-oc.yml | Removes obsolete OC compare fixture. |
| e2e-tests/demand-backup-sharded/compare/statefulset_some-name-cfg-4-oc.yml | Removes obsolete OC compare fixture. |
| e2e-tests/demand-backup-fs/run | Normalizes OpenShift checks/quoting. |
| e2e-tests/demand-backup-eks-credentials/run | Uses numeric EKS flag check consistent with new platform detection. |
| e2e-tests/demand-backup-eks-credentials-irsa/run | Uses numeric EKS flag check consistent with new platform detection. |
| e2e-tests/default-cr/compare/statefulset_my-cluster-name-rs0.yml | Updates expected volumes/mounts (keyfile removal) for default CR fixtures. |
| e2e-tests/default-cr/compare/statefulset_my-cluster-name-rs0-oc.yml | Same fixture update for OpenShift. |
| e2e-tests/default-cr/compare/statefulset_my-cluster-name-cfg.yml | Same fixture update for cfg statefulset. |
| e2e-tests/default-cr/compare/statefulset_my-cluster-name-cfg-oc.yml | Same fixture update for cfg statefulset on OpenShift. |
| e2e-tests/default-cr/compare/statefulset_minimal-cluster-rs0.yml | Updates expected volumes/mounts (keyfile removal) for minimal CR fixtures. |
| e2e-tests/default-cr/compare/statefulset_minimal-cluster-rs0-oc.yml | Same fixture update for OpenShift. |
| e2e-tests/default-cr/compare/statefulset_minimal-cluster-cfg.yml | Same fixture update for cfg statefulset. |
| e2e-tests/default-cr/compare/statefulset_minimal-cluster-cfg-oc.yml | Same fixture update for cfg statefulset on OpenShift. |
| e2e-tests/custom-users-roles-sharded/run | Replaces inline RuntimeClass logic with create_runtime_class. |
| e2e-tests/custom-users-roles-sharded/compare/run | Same RuntimeClass helper change for compare runner. |
| e2e-tests/custom-users-roles-sharded/compare/statefulset_some-name-rs0-oc.yml | Updates OC fixture to include runtimeClassName. |
| e2e-tests/custom-users-roles-sharded/compare/statefulset_some-name-mongos-oc.yml | Updates OC fixture (securityContext placement + runtimeClassName). |
| e2e-tests/custom-users-roles-sharded/compare/statefulset_some-name-cfg-oc.yml | Updates OC fixture to include runtimeClassName. |
| e2e-tests/custom-users-roles-sharded/compare/statefulset_some-name-rs0-4-oc.yml | Removes obsolete OC compare fixture. |
| e2e-tests/custom-users-roles-sharded/compare/statefulset_some-name-mongos-4-oc.yml | Removes obsolete OC compare fixture. |
| e2e-tests/custom-users-roles-sharded/compare/statefulset_some-name-cfg-4-oc.yml | Removes obsolete OC compare fixture. |
| e2e-tests/conf/volume-snapshot-class-rancher.yaml | Adds Longhorn/Rancher VolumeSnapshotClass definition. |
| e2e-tests/conf/volume-snapshot-class-gke.yaml | Adds/defines GKE VolumeSnapshotClass definition. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
527a646 to
acb5c4c
Compare
Collaborator
commit: 25599b5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Solution:
Fixes and improvements for Rancher tests
Additional changes
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability