Skip to content

K8SPSMDB-1654: Vector search fixes/improvements#2437

Open
egegunes wants to merge 4 commits into
mainfrom
K8SPSMDB-1654
Open

K8SPSMDB-1654: Vector search fixes/improvements#2437
egegunes wants to merge 4 commits into
mainfrom
K8SPSMDB-1654

Conversation

@egegunes

@egegunes egegunes commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

CHANGE DESCRIPTION

  • Mongot statefulset shouldn't be created for config server replset.
  • Update mongot configuration to support changes in upstream.
  • Use mongot image provided by Percona.

@egegunes egegunes added this to the v1.23.0 milestone Jul 6, 2026
@pull-request-size pull-request-size Bot added the size/L 100-499 lines label Jul 6, 2026
@egegunes egegunes requested a review from Copilot July 6, 2026 11:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the operator’s Vector Search (mongot) integration to align with upstream configuration changes and Percona’s mongot image, while avoiding mongot deployment for config-server replsets and improving overall readiness reporting.

Changes:

  • Skip mongot reconciliation for config-server replsets; incorporate mongot status into cluster readiness evaluation.
  • Update generated mongot config schema (ScramAuth/X509 layout, replicationReader additions) and adjust passwordFile handling to use a copied file under /tmp.
  • Switch e2e default mongot image and update entrypoint behavior for TLS PEM creation and password file preparation.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
pkg/psmdb/vectorsearch/statefulset.go Updates mongot container args and removes unused secret mounts/volumes.
pkg/psmdb/vectorsearch/statefulset_test.go Adjusts expected mongot command.
pkg/psmdb/vectorsearch/mongot/config.go Updates Go structs representing mongot configuration schema.
pkg/psmdb/vectorsearch/config.go Updates default mongot config generation to use ScramAuth and /tmp passwordFile.
pkg/psmdb/vectorsearch/config_test.go Updates expected rendered config to match new schema/passwordFile.
pkg/controller/perconaservermongodb/status.go Includes mongot readiness in overall cluster state.
pkg/controller/perconaservermongodb/search.go Skips mongot reconciliation for config-server replsets.
pkg/apis/psmdb/v1/psmdb_defaults.go Adds default pod/container security context for Search.
e2e-tests/functions Switches default IMAGE_SEARCH to Percona mongot image/tag.
build/mongot-entrypoint.sh Prepares TLS PEM and copies/chmods search password file for mongot.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pkg/psmdb/vectorsearch/mongot/config.go
Comment thread pkg/controller/perconaservermongodb/search.go
Comment thread build/mongot-entrypoint.sh
Comment thread build/mongot-entrypoint.sh

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Comment thread pkg/apis/psmdb/v1/psmdb_defaults.go
- Mongot statefulset shouldn't be created for config server replset.
- Update mongot configuration to support changes in upstream.
- Use mongot image provided by Percona.
mayankshah1607
mayankshah1607 previously approved these changes Jul 7, 2026
gkech
gkech previously approved these changes Jul 7, 2026
hors
hors previously approved these changes Jul 7, 2026
Comment thread e2e-tests/functions Outdated
perconalab/percona-server-mongodb-operator:main-mongod8.0'}
IMAGE_BACKUP=${IMAGE_BACKUP:-"perconalab/percona-server-mongodb-operator:main-backup"}
IMAGE_SEARCH=${IMAGE_SEARCH:-"mongodb/mongodb-community-search:latest"}
IMAGE_SEARCH=${IMAGE_SEARCH:-"perconalab/percona-server-mongodb-mongot:0.51.0"}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a Dockerfile? If yes, we need to start building this image in our Jenkins job and use it as perconalab/percona-server-mongodb-operator:main-mongot

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Percona-Lab/jenkins-pipelines#4241
I have created PR, @egegunes please check

@hors hors dismissed stale reviews from gkech and themself via b15d079 July 8, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants