PT-2421 - Adding further data collection to pt-k8s-debug-collector#1141
Open
eslavyansky wants to merge 4 commits into
Open
PT-2421 - Adding further data collection to pt-k8s-debug-collector#1141eslavyansky wants to merge 4 commits into
eslavyansky wants to merge 4 commits into
Conversation
This PR introduces additional files in to the final dump archive for pgv2. Tool logs: - patronictl list - pgbackrest info Log files from folders: - $PGDATA/log - pgdata/pgbackrest/log
eslavyansky
force-pushed
the
PT-2421-pgbackrest-info-collection
branch
from
6acedd9 to
c290de3
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends pt-k8s-debug-collector’s PG v2 (“pgv2”) collection to include additional pgBackRest logs and command outputs in the generated dump archive, and updates the integration test suite to validate those artifacts are present.
Changes:
- Add collection of
pgdata/pgbackrest/loginto the dump archive forpgv2. - Add “tool log” collection for
pgv2by executingpatronictl listandpgbackrest infoin the database container and archiving the outputs as files. - Extend
TestIndividualFilescoverage to assert the newpgv2log files are present incluster-dump.tar.gz.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/go/pt-k8s-debug-collector/main_test.go | Adds pgv2 assertions for pgBackRest log files and tool-output log files in the archive. |
| src/go/pt-k8s-debug-collector/dumper/resources.go | Registers new pgv2 directory dump (pgbackrest_log) and tool commands to run. |
| src/go/pt-k8s-debug-collector/dumper/individual_files.go | Implements execution + archiving of tool outputs via processToolOutput. |
| src/go/pt-k8s-debug-collector/dumper/dumper.go | Introduces the toolLog type and adds toolCmds to individualFile. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Collaborator
|
Two issues with this PR:
Actually, tool exhibits correct behavior, because if resource none is specified, only K8 resourses should be collected, not database-specific. I noticed you implemented it for pgv2 only. This maybe OK, because we need to deprecate pgo, but user manual should also mention it. |
svetasmirnova
requested changes
Jun 26, 2026
svetasmirnova
left a comment
svetasmirnova
left a comment
Collaborator
There was a problem hiding this comment.
See my previous comment.
With --resource none only general Kubernetes data is collected, not database-specific files, so TestIndividualFiles must not expect them. Add a skipForNone flag and skip those checks when the resource is none, while keeping the pod container log check (collected for every resource). Drop the now-redundant tar-error guard so genuine failures are not masked.
List the individual files and tool command outputs that are collected for PostgreSQL Operator v2 (pgv2).
Contributor
Author
|
@svetasmirnova check please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces additional files in to the final dump archive for pgv2.
Tool logs:
Log files from folders:
$PGDATA/log
pgdata/pgbackrest/log
The contributed code is licensed under GPL v2.0
Contributor Licence Agreement (CLA) is signed
util/update-modules has been ran
Documentation updated
Test suite update