Option to Set Dynamic Minimum Chunk Size#854
Open
ahirreddy wants to merge 2 commits into
Open
Conversation
|
|
svetasmirnova
requested changes
Dec 26, 2024
svetasmirnova
left a comment
svetasmirnova
left a comment
Collaborator
There was a problem hiding this comment.
Please add a test case. You can find examples in t/pt-online-schema-change
Collaborator
|
Don't forget to add a test when the last chunk that copies the last few rows from the original table is smaller than the dynamic minimum chunk size. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a flag that allows one to set the minimum/floor on the dynamic chunk size.
This is important for use-cases in which a table has a insert rate that exceeds that which is allowed by the dynamically selected chunk size.
The contributed code is licensed under GPL v2.0
Contributor Licence Agreement (CLA) is signed
util/update-modules has been ran
Documentation updated
Test suite update