K8SPXC-1843: fix handle_sigterm in run_backup.sh #2427
Open
pooknull wants to merge 19 commits into
Open
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPXC-1843
DESCRIPTION
Problem:
If the joiner/garbd and donor disconnect from each other, the backup can remain stuck in the
Runningstate instead of failing.Cause:
run_backup.shdid not handleSIGTERMfrom the interrupted SST. In the this scenario, the script could stay in an incomplete state instead of exiting with an error, so the backup job never failed.Solution:
Replace
if ((FIRST_RECEIVED == 0))check, which previously made the backup job hanging, withexit 1CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability