Skip to content

Commit fe957de

Browse files
committed
Use <> rather than "" for PostgreSQL headers
These are not local to this project in any way, so use <> for them.
1 parent 63e41bb commit fe957de

5 files changed

Lines changed: 46 additions & 46 deletions

File tree

.github/workflows/check.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434
working-directory: src/pg_stat_monitor
3535
run: |
3636
set -x
37-
cppcheck --enable=all --inline-suppr --template='{file}:{line},{severity},{id},{message}' --error-exitcode=1 --suppress=missingIncludeSystem --suppress=missingInclude --suppress=unmatchedSuppression:pg_stat_monitor.c --check-config .
37+
cppcheck --enable=all --inline-suppr --template='{file}:{line},{severity},{id},{message}' --error-exitcode=1 --suppress=missingIncludeSystem --suppress=unmatchedSuppression:pg_stat_monitor.c --check-config .
3838
3939
format:
4040
name: Format

guc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
*
1515
*-------------------------------------------------------------------------
1616
*/
17-
#include "postgres.h"
17+
#include <postgres.h>
1818

1919
#include "pg_stat_monitor.h"
2020

hash_query.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@
1414
*
1515
*-------------------------------------------------------------------------
1616
*/
17-
#include "postgres.h"
17+
#include <postgres.h>
1818

19-
#include "storage/ipc.h"
20-
#include "storage/shmem.h"
21-
#include "utils/memutils.h"
19+
#include <storage/ipc.h>
20+
#include <storage/shmem.h>
21+
#include <utils/memutils.h>
2222

2323
#include "pg_stat_monitor.h"
2424

pg_stat_monitor.c

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -15,43 +15,43 @@
1515
*-------------------------------------------------------------------------
1616
*/
1717

18-
#include "postgres.h"
18+
#include <postgres.h>
1919

2020
#include <arpa/inet.h>
2121
#include <math.h>
2222
#include <sys/resource.h>
2323
#include <sys/time.h>
2424

25-
#include "access/hash.h"
26-
#include "access/parallel.h"
27-
#include "access/xact.h"
28-
#include "catalog/pg_authid.h"
29-
#include "commands/dbcommands.h"
30-
#include "commands/explain.h"
31-
#include "common/ip.h"
32-
#include "funcapi.h"
33-
#include "jit/jit.h"
34-
#include "mb/pg_wchar.h"
35-
#include "miscadmin.h"
36-
#include "nodes/pg_list.h"
37-
#include "optimizer/planner.h"
38-
#include "parser/analyze.h"
39-
#include "parser/parsetree.h"
40-
#include "parser/scanner.h"
41-
#include "parser/scansup.h"
42-
#include "pgstat.h"
43-
#include "storage/ipc.h"
44-
#include "storage/proc.h"
45-
#include "storage/shmem.h"
46-
#include "tcop/utility.h"
47-
#include "utils/acl.h"
48-
#include "utils/builtins.h"
49-
#include "utils/lsyscache.h"
50-
#include "utils/memutils.h"
25+
#include <access/hash.h>
26+
#include <access/parallel.h>
27+
#include <access/xact.h>
28+
#include <catalog/pg_authid.h>
29+
#include <commands/dbcommands.h>
30+
#include <commands/explain.h>
31+
#include <common/ip.h>
32+
#include <funcapi.h>
33+
#include <jit/jit.h>
34+
#include <mb/pg_wchar.h>
35+
#include <miscadmin.h>
36+
#include <nodes/pg_list.h>
37+
#include <optimizer/planner.h>
38+
#include <parser/analyze.h>
39+
#include <parser/parsetree.h>
40+
#include <parser/scanner.h>
41+
#include <parser/scansup.h>
42+
#include <pgstat.h>
43+
#include <storage/ipc.h>
44+
#include <storage/proc.h>
45+
#include <storage/shmem.h>
46+
#include <tcop/utility.h>
47+
#include <utils/acl.h>
48+
#include <utils/builtins.h>
49+
#include <utils/lsyscache.h>
50+
#include <utils/memutils.h>
5151

5252
#if PG_VERSION_NUM >= 180000
53-
#include "commands/explain_state.h"
54-
#include "commands/explain_format.h"
53+
#include <commands/explain_state.h>
54+
#include <commands/explain_format.h>
5555
#endif
5656

5757
#include "pg_stat_monitor.h"

pg_stat_monitor.h

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -17,17 +17,17 @@
1717
#ifndef __PG_STAT_MONITOR_H__
1818
#define __PG_STAT_MONITOR_H__
1919

20-
#include "postgres.h"
21-
22-
#include "executor/instrument.h"
23-
#include "lib/dshash.h"
24-
#include "nodes/nodes.h"
25-
#include "storage/lwlock.h"
26-
#include "storage/spin.h"
27-
#include "utils/dsa.h"
28-
#include "utils/guc.h"
29-
#include "utils/hsearch.h"
30-
#include "utils/timestamp.h"
20+
#include <postgres.h>
21+
22+
#include <executor/instrument.h>
23+
#include <lib/dshash.h>
24+
#include <nodes/nodes.h>
25+
#include <storage/lwlock.h>
26+
#include <storage/spin.h>
27+
#include <utils/dsa.h>
28+
#include <utils/guc.h>
29+
#include <utils/hsearch.h>
30+
#include <utils/timestamp.h>
3131

3232

3333
/* XXX: Should USAGE_EXEC reflect execution time and/or buffer usage? */

0 commit comments

Comments
 (0)