Skip to content

Makefile format and cleanup#633

Merged
artemgavrilov merged 2 commits into
mainfrom
makefile
Apr 2, 2026
Merged

Makefile format and cleanup#633
artemgavrilov merged 2 commits into
mainfrom
makefile

Conversation

@artemgavrilov
Copy link
Copy Markdown
Contributor

@artemgavrilov artemgavrilov commented Mar 13, 2026

Description

Remove redundant stuff and add a little bit of formatting.

Links

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.96%. Comparing base (1b6b7cb) to head (186bee6).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #633      +/-   ##
==========================================
+ Coverage   85.81%   85.96%   +0.14%     
==========================================
  Files           3        3              
  Lines        1354     1354              
  Branches      218      218              
==========================================
+ Hits         1162     1164       +2     
+ Misses         91       90       -1     
+ Partials      101      100       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@artemgavrilov artemgavrilov changed the title Makefile updates Makefile format and cleanup Mar 13, 2026
Comment thread Makefile
@artemgavrilov artemgavrilov marked this pull request as ready for review March 13, 2026 16:17
@AndersAstrand
Copy link
Copy Markdown
Contributor

I think that, when we rework how we build pg_stat_monitor we should also remove all notions of pg_stat_monitor being a submodule of the main postgresql repository.

@artemgavrilov
Copy link
Copy Markdown
Contributor Author

@AndersAstrand Some other third party extensions use this approach and even in Issues we have and ask about adding EXTRA_INSTALL option that make sense only for contrib way of build. Do we want to abandon that and go only with PGSX?

@AndersAstrand
Copy link
Copy Markdown
Contributor

@AndersAstrand Some other third party extensions use this approach and even in Issues we have and ask about adding EXTRA_INSTALL option that make sense only for contrib way of build. Do we want to abandon that and go only with PGSX?

I'd say definitely yes, but maybe we need to have a discussion in the team. For pg_tde we abandoned the submodule stuff and I think we should do it for everything.

@artemgavrilov
Copy link
Copy Markdown
Contributor Author

After discussion within team we decided to drop contrib way of building extension and support only PGXS.

@artemgavrilov artemgavrilov marked this pull request as draft March 20, 2026 17:29
This field was holding pg_stat_statements description. Update in with
pg_stat_monitor once.
@artemgavrilov artemgavrilov marked this pull request as ready for review March 25, 2026 13:10
@artemgavrilov artemgavrilov merged commit ee63c77 into main Apr 2, 2026
50 of 51 checks passed
@artemgavrilov artemgavrilov deleted the makefile branch April 2, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants