Clean up get_histogram_bucket()#753
Open
jeltz wants to merge 1 commit into
Open
Conversation
In commit b2e5c69 I accidentally pushed the wrong thing plus a typo in a comment. While at it also remove a pointless lower range check because we already know that as we loop from low to high.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #753 +/- ##
==========================================
- Coverage 88.36% 88.13% -0.23%
==========================================
Files 3 3
Lines 1332 1332
Branches 202 202
==========================================
- Hits 1177 1174 -3
- Misses 72 74 +2
- Partials 83 84 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dutow
reviewed
Jul 4, 2026
| } | ||
|
|
||
| /* Given the uppermost bound is inifity we should never reach this */ | ||
| /* Given the uppermost bound is infinity we should never reach this */ |
Contributor
There was a problem hiding this comment.
The cleanup looks good, but is this comment always true?
else if (index == b_count - 1 && q_max < HISTOGRAM_MAX_TIME)
{
*b_start = q_max;
*b_end = INFINITY;
return;
}
But it can be also HISTOGRAM_MAX_TIME, in which case we don't add infinity.
| static int | ||
| get_histogram_bucket(double q_time) | ||
| { | ||
| for (int index = 0; index < hist_bucket_count_total - 1; index++) |
Contributor
There was a problem hiding this comment.
I thought it was done intentionally. We don't check last bucket as it's always has open end bound and we will return this bucket as last option on line 3139.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In commit b2e5c69 I accidentally pushed the wrong thing plus a typo in a comment. While at it also remove a pointless lower range check because we already know that as we loop from low to high.
PG-0
Question for the reviewers: I am not sure what the cleanest way to write this function is but what I accidentally merged was a bit of mess where the comment contradicted the code.