Skip to content

Do not pass default params to psql() in TAP tests#763

Merged
jeltz merged 1 commit into
percona:mainfrom
jeltz:tap-psql-defaults
Jul 7, 2026
Merged

Do not pass default params to psql() in TAP tests#763
jeltz merged 1 commit into
percona:mainfrom
jeltz:tap-psql-defaults

Conversation

@jeltz

@jeltz jeltz commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Make the intent of the code more clear by not passing default arguments to the psql() function. The unaligned format and tuples_only are defaults in the test helper.

PG-0

Make the intent of the code more clear by not passing default arguments
to the psql() function. The unaligned format and tuples_only are
defaults in the test helper.
@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.31%. Comparing base (4216f3b) to head (60ac230).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #763      +/-   ##
==========================================
+ Coverage   88.16%   88.31%   +0.15%     
==========================================
  Files           3        3              
  Lines        1327     1327              
  Branches      201      201              
==========================================
+ Hits         1170     1172       +2     
+ Misses         73       72       -1     
+ Partials       84       83       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jeltz jeltz merged commit a6eb046 into percona:main Jul 7, 2026
71 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants