Run CI actions for PGSM with assertions enabled#766
Draft
jeltz wants to merge 1 commit into
Draft
Conversation
jeltz
force-pushed
the
ci-casserts
branch
4 times, most recently
from
6f00e0f to
43567c7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #766 +/- ##
=======================================
Coverage 88.14% 88.14%
=======================================
Files 3 3
Lines 1324 1324
Branches 198 198
=======================================
Hits 1167 1167
Misses 73 73
Partials 84 84 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jeltz
force-pushed
the
ci-casserts
branch
4 times, most recently
from
93c91b7 to
25e40a5
Compare
While the sanitizer checks were ran with assertions enabled I do not think that is enough. We want to test with assertions enabled on all versions of PostgreSQL that we support. To save some CPU cycles now that we will build much more we only build with gcc against packages on Linux. Also disable building with injection points for now until we have some test case which actually uses them since PostgreSQL version before 17 did not support them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the sanitizer checks were ran with assertions enabled I do not think that is enough. We want to test with assertions enabled on all versions of PostgreSQL that we support.
To save some CPU cycles now that we will build much more we only build with gcc against packages on Linux.
Also disable building with injection points for now until we have some test case which actually uses them since PostgreSQL version before 17 did not support them.
PG-0