Stop trying to handle the case of the empty string as a query plan#767
Open
jeltz wants to merge 1 commit into
Open
Stop trying to handle the case of the empty string as a query plan#767jeltz wants to merge 1 commit into
jeltz wants to merge 1 commit into
Conversation
We will never get the empty string as a query plan so do not bother having extra code which tries to handle it. And if we, as this patch does, just treats it as an actual query plan everything works just fine so there is no reason to make things complicated.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #767 +/- ##
==========================================
+ Coverage 88.14% 88.28% +0.14%
==========================================
Files 3 3
Lines 1324 1323 -1
Branches 198 198
==========================================
+ Hits 1167 1168 +1
+ Misses 73 72 -1
+ Partials 84 83 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We will never get the empty string as a query plan so do not bother having extra code which tries to handle it. And if we, as this patch does, just treats it as an actual query plan everything works just fine so there is no reason to make things complicated.
PG-0