Skip to content

Update architecture/index.md#439

Merged
Andriciuc merged 12 commits into
release-17.5.2from
index-update-based-on-AA-feedback
Jun 30, 2025
Merged

Update architecture/index.md#439
Andriciuc merged 12 commits into
release-17.5.2from
index-update-based-on-AA-feedback

Conversation

@Andriciuc

Copy link
Copy Markdown
Collaborator

Updated the Architecture topic with the following:

  • New intro detailing the long term tde goals in a paragraph
  • Updated the ## Typical setup scenarios topic with better writing and improved flow
  • Added note to WAL Encryption that it is not to be used in prod env
  • General small fixes to paragraphs, wrongly written words and such

Updated the Architecture topic with the following:
- New intro detailing the long term tde goals in a paragraph
- Updated the ## Typical setup scenarios topic with better writing and improved flow
- Added note to WAL Encryption that it is not to be used in prod env
- General small fixes to paragraphs, wrongly written words and such
@codecov-commenter

codecov-commenter commented Jun 17, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-17.5.2@dfcef9f). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             release-17.5.2     #439   +/-   ##
=================================================
  Coverage                  ?   84.68%           
=================================================
  Files                     ?       21           
  Lines                     ?     2593           
  Branches                  ?      401           
=================================================
  Hits                      ?     2196           
  Misses                    ?      316           
  Partials                  ?       81           
Components Coverage Δ
access 81.11% <0.00%> (?)
catalog 88.22% <0.00%> (?)
common 77.77% <0.00%> (?)
encryption 73.45% <0.00%> (?)
keyring 72.88% <0.00%> (?)
src 91.54% <0.00%> (?)
smgr 94.85% <0.00%> (?)
transam ∅ <0.00%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread contrib/pg_tde/documentation/docs/architecture/index.md Outdated
Comment thread contrib/pg_tde/documentation/docs/architecture/index.md Outdated
Comment thread contrib/pg_tde/documentation/docs/architecture/index.md Outdated
Comment thread contrib/pg_tde/documentation/docs/architecture/index.md Outdated
* reworded intro paragraphs for better flow
* Improved headings and some paragraphs throughout the file to be present tense
* improved Add providers with link to parameter and paragraph flow
* Reworded Simple "one principal key" encryption step 5 and note and id the same for Complete multi-tenancy
@Andriciuc

Copy link
Copy Markdown
Collaborator Author

Updated the Architecture topic with the following:

  • New intro detailing the long term tde goals in a paragraph
  • Updated the ## Typical setup scenarios topic with better writing and improved flow
  • Added note to WAL Encryption that it is not to be used in prod env
  • General small fixes to paragraphs, wrongly written words and such

@Andriciuc Andriciuc requested a review from dutow June 18, 2025 08:27
@Andriciuc Andriciuc marked this pull request as ready for review June 18, 2025 08:27
@Andriciuc Andriciuc requested a review from nastena1606 as a code owner June 18, 2025 08:27
@Andriciuc Andriciuc requested a review from AndersAstrand June 18, 2025 08:44
Comment thread contrib/pg_tde/documentation/docs/architecture/index.md Outdated
@Andriciuc Andriciuc removed their assignment Jun 25, 2025
Removed  "and `pg_tde.wal_encrypt`"
Comment thread contrib/pg_tde/documentation/docs/architecture/index.md Outdated
Comment thread contrib/pg_tde/documentation/docs/architecture/index.md Outdated
Comment thread contrib/pg_tde/documentation/docs/architecture/index.md
Comment thread contrib/pg_tde/documentation/docs/architecture/index.md Outdated
Comment thread contrib/pg_tde/documentation/docs/architecture/index.md Outdated
Comment thread contrib/pg_tde/documentation/docs/architecture/index.md Outdated
Comment thread contrib/pg_tde/documentation/docs/architecture/index.md Outdated
removed unneeded note These functions do not verify the parameters. To verify them, see [`pg_tde_verify_key`](../functions.md#pg_tde_verify_key).

added note for `pg_tde_change_key_provider` command line tool

deleted unneeded paragraph
removed WAL for ## Typical setup scenarios ### Simple "one principal key" encryption

removed typical setup scenarios as they are outdated and confuse the users
@nastena1606 nastena1606 temporarily deployed to index-update-based-on-AA-feedback - pg-tde-docs PR #439 June 27, 2025 13:27 — with Render Destroyed

@Andriciuc Andriciuc left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed typical setup scenarios as they are outdated and confuse the users and updated content based on feedback

Comment thread contrib/pg_tde/documentation/docs/architecture/index.md Outdated
@AndersAstrand AndersAstrand changed the title Updated architecture/index.md based on AA feedback Updated architecture/index.md based on feedback Jun 30, 2025
@Andriciuc Andriciuc changed the title Updated architecture/index.md based on feedback Updated architecture/index.md Jun 30, 2025
@Andriciuc Andriciuc changed the title Updated architecture/index.md Update architecture/index.md Jun 30, 2025
Comment thread contrib/pg_tde/documentation/docs/architecture/index.md Outdated
Comment thread contrib/pg_tde/documentation/docs/architecture/index.md
reworded introduction to architecture topic
@nastena1606 nastena1606 temporarily deployed to index-update-based-on-AA-feedback - pg-tde-docs PR #439 June 30, 2025 12:01 — with Render Destroyed
@nastena1606 nastena1606 temporarily deployed to index-update-based-on-AA-feedback - pg-tde-docs PR #439 June 30, 2025 12:13 — with Render Destroyed
@Andriciuc Andriciuc merged commit b6c1305 into release-17.5.2 Jun 30, 2025
16 of 22 checks passed
@Andriciuc Andriciuc deleted the index-update-based-on-AA-feedback branch June 30, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants