Avoid mutable default for toolsets#36
Open
kingrubic wants to merge 1 commit into
Open
Conversation
kingrubic
force-pushed
the
avoid-mutable-toolsets-default
branch
from
3f0a8e6 to
671c848
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Noneas the default constructor value fortoolsetsself.toolsetsto a fresh empty list when omittedWhy
Using a list as a default argument can accidentally share state between instances. This keeps the current omitted-argument behavior while avoiding that Python footgun.
Tests
python3 -m compileall -q p4mcp