Fix about name of waypoints#610
Open
renanr0 wants to merge 1 commit intoperliedman:masterfrom
Open
Conversation
… name has no value
Owner
|
After dragging the waypoint, the name should be cleared since it is no longer the same location. It's confusing if the old address is displayed even after dragging the waypoint. Can you explain why you need this change? |
Author
|
Sure, in some cases of use, it's necessary to use the name of waypoint instead of the address. For example, I name some waypoints with custom names (home, work ...), and when I drag these points I lost the name. I understand if the library prefers not to accept this change, I'm just sharing a different use case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure assign name of waypoint with empty string only if the original name has no value.