Add note regarding OpenRoute Service plugins#641
Open
saerdnaer wants to merge 1 commit intoperliedman:masterfrom
Open
Add note regarding OpenRoute Service plugins#641saerdnaer wants to merge 1 commit intoperliedman:masterfrom
saerdnaer wants to merge 1 commit intoperliedman:masterfrom
Conversation
curtisy1
reviewed
Oct 15, 2021
Collaborator
curtisy1
left a comment
curtisy1
left a comment
There was a problem hiding this comment.
Thanks for the PR @saerdnaer
I have one small request before merging this if you don't mind. The other plugins all have some sort of "name" (e.g. Mapzen Valhalla - through plugin lrm-valhalla) so it would probably make sense to also name the OpenRouteService plugins accordingly. I'm thinking of something like
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.